Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

selftests/resctrl: Fix resctrl_tests' return code to work with selftest framework

In kselftest framework, if a sub test can not run by some reasons,
the test result should be marked as SKIP rather than FAIL.
Return KSFT_SKIP(4) instead of KSFT_FAIL(1) if resctrl_tests is not run
as root or it is run on a test environment which does not support resctrl.

- ksft_exit_fail_msg(): returns KSFT_FAIL(1)
- ksft_exit_skip(): returns KSFT_SKIP(4)

Reviewed-by: Shuah Khan <skhan@linuxfoundation.org>
Reviewed-by: Reinette Chatre <reinette.chatre@intel.com>
Reviewed-by: Fenghua Yu <fenghua.yu@intel.com>
Signed-off-by: Shaopeng Tan <tan.shaopeng@jp.fujitsu.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>

authored by

Shaopeng Tan and committed by
Shuah Khan
3531d930 e2e3fb6e

+2 -2
+2 -2
tools/testing/selftests/resctrl/resctrl_tests.c
··· 225 225 * 2. We execute perf commands 226 226 */ 227 227 if (geteuid() != 0) 228 - return ksft_exit_fail_msg("Not running as root, abort testing.\n"); 228 + return ksft_exit_skip("Not running as root. Skipping...\n"); 229 229 230 230 if (has_ben) { 231 231 /* Extract benchmark command from command line. */ ··· 252 252 sprintf(bm_type, "fill_buf"); 253 253 254 254 if (!check_resctrlfs_support()) 255 - return ksft_exit_fail_msg("resctrl FS does not exist\n"); 255 + return ksft_exit_skip("resctrl FS does not exist. Enable X86_CPU_RESCTRL config option.\n"); 256 256 257 257 filter_dmesg(); 258 258