Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

usb: phy: qcom: New APQ8016/MSM8916 USB transceiver driver

Driver handles PHY initialization, clock management, power
management and workarounds required after resetting the hardware.

Signed-off-by: Ivan T. Ivanov <ivan.ivanov@linaro.org>
Signed-off-by: Felipe Balbi <balbi@ti.com>

authored by

Ivan T. Ivanov and committed by
Felipe Balbi
35116993 75ddead2

+527
+76
Documentation/devicetree/bindings/usb/qcom,usb-8x16-phy.txt
··· 1 + Qualcomm's APQ8016/MSM8916 USB transceiver controller 2 + 3 + - compatible: 4 + Usage: required 5 + Value type: <string> 6 + Definition: Should contain "qcom,usb-8x16-phy". 7 + 8 + - reg: 9 + Usage: required 10 + Value type: <prop-encoded-array> 11 + Definition: USB PHY base address and length of the register map 12 + 13 + - clocks: 14 + Usage: required 15 + Value type: <prop-encoded-array> 16 + Definition: See clock-bindings.txt section "consumers". List of 17 + two clock specifiers for interface and core controller 18 + clocks. 19 + 20 + - clock-names: 21 + Usage: required 22 + Value type: <string> 23 + Definition: Must contain "iface" and "core" strings. 24 + 25 + - vddcx-supply: 26 + Usage: required 27 + Value type: <phandle> 28 + Definition: phandle to the regulator VDCCX supply node. 29 + 30 + - v1p8-supply: 31 + Usage: required 32 + Value type: <phandle> 33 + Definition: phandle to the regulator 1.8V supply node. 34 + 35 + - v3p3-supply: 36 + Usage: required 37 + Value type: <phandle> 38 + Definition: phandle to the regulator 3.3V supply node. 39 + 40 + - resets: 41 + Usage: required 42 + Value type: <prop-encoded-array> 43 + Definition: See reset.txt section "consumers". PHY reset specifier. 44 + 45 + - reset-names: 46 + Usage: required 47 + Value type: <string> 48 + Definition: Must contain "phy" string. 49 + 50 + - switch-gpio: 51 + Usage: optional 52 + Value type: <prop-encoded-array> 53 + Definition: Some boards are using Dual SPDT USB Switch, witch is 54 + controlled by GPIO to de/multiplex D+/D- USB lines 55 + between connectors. 56 + 57 + Example: 58 + usb_phy: phy@78d9000 { 59 + compatible = "qcom,usb-8x16-phy"; 60 + reg = <0x78d9000 0x400>; 61 + 62 + vddcx-supply = <&pm8916_s1_corner>; 63 + v1p8-supply = <&pm8916_l7>; 64 + v3p3-supply = <&pm8916_l13>; 65 + 66 + clocks = <&gcc GCC_USB_HS_AHB_CLK>, 67 + <&gcc GCC_USB_HS_SYSTEM_CLK>; 68 + clock-names = "iface", "core"; 69 + 70 + resets = <&gcc GCC_USB2A_PHY_BCR>; 71 + reset-names = "phy"; 72 + 73 + // D+/D- lines: 1 - Routed to HUB, 0 - Device connector 74 + switch-gpio = <&pm8916_gpios 4 GPIO_ACTIVE_HIGH>; 75 + }; 76 +
+14
drivers/usb/phy/Kconfig
··· 152 152 This driver is not supported on boards like trout which 153 153 has an external PHY. 154 154 155 + config USB_QCOM_8X16_PHY 156 + tristate "Qualcomm APQ8016/MSM8916 on-chip USB PHY controller support" 157 + depends on ARCH_QCOM || COMPILE_TEST 158 + depends on RESET_CONTROLLER 159 + select USB_PHY 160 + select USB_ULPI_VIEWPORT 161 + help 162 + Enable this to support the USB transceiver on Qualcomm 8x16 chipsets. 163 + It handles PHY initialization, clock management, power management, 164 + and workarounds required after resetting the hardware. 165 + 166 + To compile this driver as a module, choose M here: the 167 + module will be called phy-qcom-8x16-usb. 168 + 155 169 config USB_MV_OTG 156 170 tristate "Marvell USB OTG support" 157 171 depends on USB_EHCI_MV && USB_MV_UDC && PM
+1
drivers/usb/phy/Makefile
··· 20 20 obj-$(CONFIG_USB_GPIO_VBUS) += phy-gpio-vbus-usb.o 21 21 obj-$(CONFIG_USB_ISP1301) += phy-isp1301.o 22 22 obj-$(CONFIG_USB_MSM_OTG) += phy-msm-usb.o 23 + obj-$(CONFIG_USB_QCOM_8X16_PHY) += phy-qcom-8x16-usb.o 23 24 obj-$(CONFIG_USB_MV_OTG) += phy-mv-usb.o 24 25 obj-$(CONFIG_USB_MXS_PHY) += phy-mxs-usb.o 25 26 obj-$(CONFIG_USB_RCAR_PHY) += phy-rcar-usb.o
+436
drivers/usb/phy/phy-qcom-8x16-usb.c
··· 1 + /* 2 + * Copyright (c) 2015, Linaro Limited 3 + * 4 + * This program is free software; you can redistribute it and/or modify 5 + * it under the terms of the GNU General Public License version 2 and 6 + * only version 2 as published by the Free Software Foundation. 7 + * 8 + * This program is distributed in the hope that it will be useful, 9 + * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 + * GNU General Public License for more details. 12 + */ 13 + 14 + #include <linux/clk.h> 15 + #include <linux/delay.h> 16 + #include <linux/device.h> 17 + #include <linux/err.h> 18 + #include <linux/extcon.h> 19 + #include <linux/gpio/consumer.h> 20 + #include <linux/io.h> 21 + #include <linux/module.h> 22 + #include <linux/of.h> 23 + #include <linux/platform_device.h> 24 + #include <linux/reboot.h> 25 + #include <linux/regulator/consumer.h> 26 + #include <linux/reset.h> 27 + #include <linux/slab.h> 28 + #include <linux/usb.h> 29 + #include <linux/usb/ulpi.h> 30 + 31 + #define HSPHY_AHBBURST 0x0090 32 + #define HSPHY_AHBMODE 0x0098 33 + #define HSPHY_GENCONFIG 0x009c 34 + #define HSPHY_GENCONFIG_2 0x00a0 35 + 36 + #define HSPHY_USBCMD 0x0140 37 + #define HSPHY_ULPI_VIEWPORT 0x0170 38 + #define HSPHY_CTRL 0x0240 39 + 40 + #define HSPHY_TXFIFO_IDLE_FORCE_DIS BIT(4) 41 + #define HSPHY_SESS_VLD_CTRL_EN BIT(7) 42 + #define HSPHY_POR_ASSERT BIT(0) 43 + #define HSPHY_RETEN BIT(1) 44 + 45 + #define HSPHY_SESS_VLD_CTRL BIT(25) 46 + 47 + #define ULPI_PWR_CLK_MNG_REG 0x88 48 + #define ULPI_PWR_OTG_COMP_DISABLE BIT(0) 49 + 50 + #define ULPI_MISC_A 0x96 51 + #define ULPI_MISC_A_VBUSVLDEXTSEL BIT(1) 52 + #define ULPI_MISC_A_VBUSVLDEXT BIT(0) 53 + 54 + #define HSPHY_3P3_MIN 3050000 /* uV */ 55 + #define HSPHY_3P3_MAX 3300000 /* uV */ 56 + 57 + #define HSPHY_1P8_MIN 1800000 /* uV */ 58 + #define HSPHY_1P8_MAX 1800000 /* uV */ 59 + 60 + #define HSPHY_VDD_MIN 5 61 + #define HSPHY_VDD_MAX 7 62 + 63 + struct phy_8x16 { 64 + struct usb_phy phy; 65 + void __iomem *regs; 66 + struct clk *core_clk; 67 + struct clk *iface_clk; 68 + struct regulator *v3p3; 69 + struct regulator *v1p8; 70 + struct regulator *vdd; 71 + 72 + struct reset_control *phy_reset; 73 + 74 + struct extcon_specific_cable_nb vbus_cable; 75 + struct notifier_block vbus_notify; 76 + 77 + struct gpio_desc *switch_gpio; 78 + struct notifier_block reboot_notify; 79 + }; 80 + 81 + static int phy_8x16_regulators_enable(struct phy_8x16 *qphy) 82 + { 83 + int ret; 84 + 85 + ret = regulator_set_voltage(qphy->vdd, HSPHY_VDD_MIN, HSPHY_VDD_MAX); 86 + if (ret) 87 + return ret; 88 + 89 + ret = regulator_enable(qphy->vdd); 90 + if (ret) 91 + return ret; 92 + 93 + ret = regulator_set_voltage(qphy->v3p3, HSPHY_3P3_MIN, HSPHY_3P3_MAX); 94 + if (ret) 95 + goto off_vdd; 96 + 97 + ret = regulator_enable(qphy->v3p3); 98 + if (ret) 99 + goto off_vdd; 100 + 101 + ret = regulator_set_voltage(qphy->v1p8, HSPHY_1P8_MIN, HSPHY_1P8_MAX); 102 + if (ret) 103 + goto off_3p3; 104 + 105 + ret = regulator_enable(qphy->v1p8); 106 + if (ret) 107 + goto off_3p3; 108 + 109 + return 0; 110 + 111 + off_3p3: 112 + regulator_disable(qphy->v3p3); 113 + off_vdd: 114 + regulator_disable(qphy->vdd); 115 + 116 + return ret; 117 + } 118 + 119 + static void phy_8x16_regulators_disable(struct phy_8x16 *qphy) 120 + { 121 + regulator_disable(qphy->v1p8); 122 + regulator_disable(qphy->v3p3); 123 + regulator_disable(qphy->vdd); 124 + } 125 + 126 + static int phy_8x16_notify_connect(struct usb_phy *phy, 127 + enum usb_device_speed speed) 128 + { 129 + struct phy_8x16 *qphy = container_of(phy, struct phy_8x16, phy); 130 + u32 val; 131 + 132 + val = ULPI_MISC_A_VBUSVLDEXTSEL | ULPI_MISC_A_VBUSVLDEXT; 133 + usb_phy_io_write(&qphy->phy, val, ULPI_SET(ULPI_MISC_A)); 134 + 135 + val = readl(qphy->regs + HSPHY_USBCMD); 136 + val |= HSPHY_SESS_VLD_CTRL; 137 + writel(val, qphy->regs + HSPHY_USBCMD); 138 + 139 + return 0; 140 + } 141 + 142 + static int phy_8x16_notify_disconnect(struct usb_phy *phy, 143 + enum usb_device_speed speed) 144 + { 145 + struct phy_8x16 *qphy = container_of(phy, struct phy_8x16, phy); 146 + u32 val; 147 + 148 + val = ULPI_MISC_A_VBUSVLDEXT | ULPI_MISC_A_VBUSVLDEXTSEL; 149 + usb_phy_io_write(&qphy->phy, val, ULPI_CLR(ULPI_MISC_A)); 150 + 151 + val = readl(qphy->regs + HSPHY_USBCMD); 152 + val &= ~HSPHY_SESS_VLD_CTRL; 153 + writel(val, qphy->regs + HSPHY_USBCMD); 154 + 155 + return 0; 156 + } 157 + 158 + static int phy_8x16_vbus_on(struct phy_8x16 *qphy) 159 + { 160 + phy_8x16_notify_connect(&qphy->phy, USB_SPEED_UNKNOWN); 161 + 162 + /* Switch D+/D- lines to Device connector */ 163 + gpiod_set_value_cansleep(qphy->switch_gpio, 0); 164 + 165 + return 0; 166 + } 167 + 168 + static int phy_8x16_vbus_off(struct phy_8x16 *qphy) 169 + { 170 + phy_8x16_notify_disconnect(&qphy->phy, USB_SPEED_UNKNOWN); 171 + 172 + /* Switch D+/D- lines to USB HUB */ 173 + gpiod_set_value_cansleep(qphy->switch_gpio, 1); 174 + 175 + return 0; 176 + } 177 + 178 + static int phy_8x16_vbus_notify(struct notifier_block *nb, unsigned long event, 179 + void *ptr) 180 + { 181 + struct phy_8x16 *qphy = container_of(nb, struct phy_8x16, vbus_notify); 182 + 183 + if (event) 184 + phy_8x16_vbus_on(qphy); 185 + else 186 + phy_8x16_vbus_off(qphy); 187 + 188 + return NOTIFY_DONE; 189 + } 190 + 191 + static int phy_8x16_init(struct usb_phy *phy) 192 + { 193 + struct phy_8x16 *qphy = container_of(phy, struct phy_8x16, phy); 194 + u32 val, init[] = {0x44, 0x6B, 0x24, 0x13}; 195 + u32 addr = ULPI_EXT_VENDOR_SPECIFIC; 196 + int idx, state; 197 + 198 + for (idx = 0; idx < ARRAY_SIZE(init); idx++) 199 + usb_phy_io_write(phy, init[idx], addr + idx); 200 + 201 + reset_control_reset(qphy->phy_reset); 202 + 203 + /* Assert USB HSPHY_POR */ 204 + val = readl(qphy->regs + HSPHY_CTRL); 205 + val |= HSPHY_POR_ASSERT; 206 + writel(val, qphy->regs + HSPHY_CTRL); 207 + 208 + /* 209 + * wait for minimum 10 microseconds as suggested in HPG. 210 + * Use a slightly larger value since the exact value didn't 211 + * work 100% of the time. 212 + */ 213 + usleep_range(12, 15); 214 + 215 + /* Deassert USB HSPHY_POR */ 216 + val = readl(qphy->regs + HSPHY_CTRL); 217 + val &= ~HSPHY_POR_ASSERT; 218 + writel(val, qphy->regs + HSPHY_CTRL); 219 + 220 + usleep_range(10, 15); 221 + 222 + writel(0x00, qphy->regs + HSPHY_AHBBURST); 223 + writel(0x08, qphy->regs + HSPHY_AHBMODE); 224 + 225 + /* workaround for rx buffer collision issue */ 226 + val = readl(qphy->regs + HSPHY_GENCONFIG); 227 + val &= ~HSPHY_TXFIFO_IDLE_FORCE_DIS; 228 + writel(val, qphy->regs + HSPHY_GENCONFIG); 229 + 230 + val = readl(qphy->regs + HSPHY_GENCONFIG_2); 231 + val |= HSPHY_SESS_VLD_CTRL_EN; 232 + writel(val, qphy->regs + HSPHY_GENCONFIG_2); 233 + 234 + val = ULPI_PWR_OTG_COMP_DISABLE; 235 + usb_phy_io_write(phy, val, ULPI_SET(ULPI_PWR_CLK_MNG_REG)); 236 + 237 + state = extcon_get_cable_state(qphy->vbus_cable.edev, "USB"); 238 + if (state) 239 + phy_8x16_vbus_on(qphy); 240 + else 241 + phy_8x16_vbus_off(qphy); 242 + 243 + val = usb_phy_io_read(&qphy->phy, ULPI_FUNC_CTRL); 244 + val &= ~ULPI_FUNC_CTRL_OPMODE_MASK; 245 + val |= ULPI_FUNC_CTRL_OPMODE_NORMAL; 246 + usb_phy_io_write(&qphy->phy, val, ULPI_FUNC_CTRL); 247 + 248 + return 0; 249 + } 250 + 251 + static void phy_8x16_shutdown(struct usb_phy *phy) 252 + { 253 + u32 val; 254 + 255 + /* Put the controller in non-driving mode */ 256 + val = usb_phy_io_read(phy, ULPI_FUNC_CTRL); 257 + val &= ~ULPI_FUNC_CTRL_OPMODE_MASK; 258 + val |= ULPI_FUNC_CTRL_OPMODE_NONDRIVING; 259 + usb_phy_io_write(phy, val, ULPI_FUNC_CTRL); 260 + } 261 + 262 + static int phy_8x16_read_devicetree(struct phy_8x16 *qphy) 263 + { 264 + struct regulator_bulk_data regs[3]; 265 + struct device *dev = qphy->phy.dev; 266 + int ret; 267 + 268 + qphy->core_clk = devm_clk_get(dev, "core"); 269 + if (IS_ERR(qphy->core_clk)) 270 + return PTR_ERR(qphy->core_clk); 271 + 272 + qphy->iface_clk = devm_clk_get(dev, "iface"); 273 + if (IS_ERR(qphy->iface_clk)) 274 + return PTR_ERR(qphy->iface_clk); 275 + 276 + regs[0].supply = "v3p3"; 277 + regs[1].supply = "v1p8"; 278 + regs[2].supply = "vddcx"; 279 + 280 + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(regs), regs); 281 + if (ret) 282 + return ret; 283 + 284 + qphy->v3p3 = regs[0].consumer; 285 + qphy->v1p8 = regs[1].consumer; 286 + qphy->vdd = regs[2].consumer; 287 + 288 + qphy->phy_reset = devm_reset_control_get(dev, "phy"); 289 + if (IS_ERR(qphy->phy_reset)) 290 + return PTR_ERR(qphy->phy_reset); 291 + 292 + qphy->switch_gpio = devm_gpiod_get_optional(dev, "switch", 293 + GPIOD_OUT_LOW); 294 + if (IS_ERR(qphy->switch_gpio)) 295 + return PTR_ERR(qphy->switch_gpio); 296 + 297 + return 0; 298 + } 299 + 300 + static int phy_8x16_reboot_notify(struct notifier_block *this, 301 + unsigned long code, void *unused) 302 + { 303 + struct phy_8x16 *qphy; 304 + 305 + qphy = container_of(this, struct phy_8x16, reboot_notify); 306 + 307 + /* 308 + * Ensure that D+/D- lines are routed to uB connector, so 309 + * we could load bootloader/kernel at next reboot_notify 310 + */ 311 + gpiod_set_value_cansleep(qphy->switch_gpio, 0); 312 + return NOTIFY_DONE; 313 + } 314 + 315 + static int phy_8x16_probe(struct platform_device *pdev) 316 + { 317 + struct extcon_dev *edev; 318 + struct phy_8x16 *qphy; 319 + struct resource *res; 320 + struct usb_phy *phy; 321 + int ret; 322 + 323 + qphy = devm_kzalloc(&pdev->dev, sizeof(*qphy), GFP_KERNEL); 324 + if (!qphy) 325 + return -ENOMEM; 326 + 327 + platform_set_drvdata(pdev, qphy); 328 + 329 + res = platform_get_resource(pdev, IORESOURCE_MEM, 0); 330 + if (!res) 331 + return -EINVAL; 332 + 333 + qphy->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res)); 334 + if (!qphy->regs) 335 + return -ENOMEM; 336 + 337 + phy = &qphy->phy; 338 + phy->dev = &pdev->dev; 339 + phy->label = dev_name(&pdev->dev); 340 + phy->init = phy_8x16_init; 341 + phy->shutdown = phy_8x16_shutdown; 342 + phy->notify_connect = phy_8x16_notify_connect; 343 + phy->notify_disconnect = phy_8x16_notify_disconnect; 344 + phy->io_priv = qphy->regs + HSPHY_ULPI_VIEWPORT; 345 + phy->io_ops = &ulpi_viewport_access_ops; 346 + phy->type = USB_PHY_TYPE_USB2; 347 + 348 + ret = phy_8x16_read_devicetree(qphy); 349 + if (ret < 0) 350 + return ret; 351 + 352 + edev = extcon_get_edev_by_phandle(phy->dev, 0); 353 + if (IS_ERR(edev)) 354 + return PTR_ERR(edev); 355 + 356 + ret = clk_set_rate(qphy->core_clk, INT_MAX); 357 + if (ret < 0) 358 + dev_dbg(phy->dev, "Can't boost core clock\n"); 359 + 360 + ret = clk_prepare_enable(qphy->core_clk); 361 + if (ret < 0) 362 + return ret; 363 + 364 + ret = clk_prepare_enable(qphy->iface_clk); 365 + if (ret < 0) 366 + goto off_core; 367 + 368 + ret = phy_8x16_regulators_enable(qphy); 369 + if (0 && ret) 370 + goto off_clks; 371 + 372 + qphy->vbus_notify.notifier_call = phy_8x16_vbus_notify; 373 + ret = extcon_register_interest(&qphy->vbus_cable, edev->name, 374 + "USB", &qphy->vbus_notify); 375 + if (ret < 0) 376 + goto off_power; 377 + 378 + ret = usb_add_phy_dev(&qphy->phy); 379 + if (ret) 380 + goto off_extcon; 381 + 382 + qphy->reboot_notify.notifier_call = phy_8x16_reboot_notify; 383 + register_reboot_notifier(&qphy->reboot_notify); 384 + 385 + return 0; 386 + 387 + off_extcon: 388 + extcon_unregister_interest(&qphy->vbus_cable); 389 + off_power: 390 + phy_8x16_regulators_disable(qphy); 391 + off_clks: 392 + clk_disable_unprepare(qphy->iface_clk); 393 + off_core: 394 + clk_disable_unprepare(qphy->core_clk); 395 + return ret; 396 + } 397 + 398 + static int phy_8x16_remove(struct platform_device *pdev) 399 + { 400 + struct phy_8x16 *qphy = platform_get_drvdata(pdev); 401 + 402 + unregister_reboot_notifier(&qphy->reboot_notify); 403 + extcon_unregister_interest(&qphy->vbus_cable); 404 + 405 + /* 406 + * Ensure that D+/D- lines are routed to uB connector, so 407 + * we could load bootloader/kernel at next reboot_notify 408 + */ 409 + gpiod_set_value_cansleep(qphy->switch_gpio, 0); 410 + 411 + usb_remove_phy(&qphy->phy); 412 + 413 + clk_disable_unprepare(qphy->iface_clk); 414 + clk_disable_unprepare(qphy->core_clk); 415 + phy_8x16_regulators_disable(qphy); 416 + return 0; 417 + } 418 + 419 + static const struct of_device_id phy_8x16_dt_match[] = { 420 + { .compatible = "qcom,usb-8x16-phy" }, 421 + { } 422 + }; 423 + MODULE_DEVICE_TABLE(of, phy_8x16_dt_match); 424 + 425 + static struct platform_driver phy_8x16_driver = { 426 + .probe = phy_8x16_probe, 427 + .remove = phy_8x16_remove, 428 + .driver = { 429 + .name = "phy-qcom-8x16-usb", 430 + .of_match_table = phy_8x16_dt_match, 431 + }, 432 + }; 433 + module_platform_driver(phy_8x16_driver); 434 + 435 + MODULE_LICENSE("GPL v2"); 436 + MODULE_DESCRIPTION("Qualcomm APQ8016/MSM8916 chipsets USB transceiver driver");