tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

x86/speculation: Remove redundant arch_smt_update() invocation

With commit a74cfffb03b7 ("x86/speculation: Rework SMT state change"),
arch_smt_update() is invoked from each individual CPU hotplug function.

Therefore the extra arch_smt_update() call in the sysfs SMT control is
redundant.

Fixes: a74cfffb03b7 ("x86/speculation: Rework SMT state change")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: <konrad.wilk@oracle.com>
Cc: <dwmw@amazon.co.uk>
Cc: <bp@suse.de>
Cc: <srinivas.eeda@oracle.com>
Cc: <peterz@infradead.org>
Cc: <hpa@zytor.com>
Link: https://lkml.kernel.org/r/e2e064f2-e8ef-42ca-bf4f-76b612964752@default

authored by Zhenzhong Duan and committed by Thomas Gleixner 34d66caf 4aa9fc2a

options
unified split
Changed files
+1 -4
kernel
cpu.c
+1 -4
kernel/cpu.c
··· 2090 2090 */ 2091 2091 cpuhp_offline_cpu_device(cpu); 2092 2092 } 2093 - if (!ret) { 2093 + if (!ret) 2094 2094 cpu_smt_control = ctrlval; 2095 - arch_smt_update(); 2096 - } 2097 2095 cpu_maps_update_done(); 2098 2096 return ret; 2099 2097 } ··· 2102 2104 2103 2105 cpu_maps_update_begin(); 2104 2106 cpu_smt_control = CPU_SMT_ENABLED; 2105 - arch_smt_update(); 2106 2107 for_each_present_cpu(cpu) { 2107 2108 /* Skip online CPUs and CPUs on offline nodes */ 2108 2109 if (cpu_online(cpu) || !node_online(cpu_to_node(cpu)))