Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

media: rkisp1: Use %pe format specifier

The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/rockchip/rkisp1/rkisp1-isp.c:940:3-10: WARNING: Consider using %pe to print PTR_ERR()
./platform/rockchip/rkisp1/rkisp1-csi.c:372:3-10: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>

authored by

Ricardo Ribalda and committed by
Hans Verkuil
34cfce1d 66725aa5

+4 -4
+2 -2
drivers/media/platform/rockchip/rkisp1/rkisp1-csi.c
··· 368 368 369 369 source_pad = media_entity_remote_source_pad_unique(&sd->entity); 370 370 if (IS_ERR(source_pad)) { 371 - dev_dbg(rkisp1->dev, "Failed to get source for CSI: %ld\n", 372 - PTR_ERR(source_pad)); 371 + dev_dbg(rkisp1->dev, "Failed to get source for CSI: %pe\n", 372 + source_pad); 373 373 return -EPIPE; 374 374 } 375 375
+2 -2
drivers/media/platform/rockchip/rkisp1/rkisp1-isp.c
··· 936 936 sink_pad = &isp->pads[RKISP1_ISP_PAD_SINK_VIDEO]; 937 937 source_pad = media_pad_remote_pad_unique(sink_pad); 938 938 if (IS_ERR(source_pad)) { 939 - dev_dbg(rkisp1->dev, "Failed to get source for ISP: %ld\n", 940 - PTR_ERR(source_pad)); 939 + dev_dbg(rkisp1->dev, "Failed to get source for ISP: %pe\n", 940 + source_pad); 941 941 return -EPIPE; 942 942 } 943 943