Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

irqchip/bcm7038-l1: Implement irq_cpu_offline() callback

We did not implement an irq_cpu_offline callback for our irqchip, yet we
support setting a given IRQ's affinity. This resulted in interrupts
whose affinity mask included CPUs being taken offline not to work
correctly once the CPU had been put offline.

Fixes: 5f7f0317ed28 ("IRQCHIP: Add new driver for BCM7038-style level 1 interrupt controllers")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-mips@linux-mips.org
Cc: jason@lakedaemon.net
Cc: marc.zyngier@arm.com
Cc: cernekee@gmail.com
Cc: jaedon.shin@gmail.com
Cc: ralf@linux-mips.org
Cc: justinpopo6@gmail.com
Link: http://lkml.kernel.org/r/1477948656-12966-2-git-send-email-f.fainelli@gmail.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

authored by

Florian Fainelli and committed by
Thomas Gleixner
34c53579 b6e5d5b9

+26
+26
drivers/irqchip/irq-bcm7038-l1.c
··· 215 215 return 0; 216 216 } 217 217 218 + static void bcm7038_l1_cpu_offline(struct irq_data *d) 219 + { 220 + struct cpumask *mask = irq_data_get_affinity_mask(d); 221 + int cpu = smp_processor_id(); 222 + cpumask_t new_affinity; 223 + 224 + /* This CPU was not on the affinity mask */ 225 + if (!cpumask_test_cpu(cpu, mask)) 226 + return; 227 + 228 + if (cpumask_weight(mask) > 1) { 229 + /* 230 + * Multiple CPU affinity, remove this CPU from the affinity 231 + * mask 232 + */ 233 + cpumask_copy(&new_affinity, mask); 234 + cpumask_clear_cpu(cpu, &new_affinity); 235 + } else { 236 + /* Only CPU, put on the lowest online CPU */ 237 + cpumask_clear(&new_affinity); 238 + cpumask_set_cpu(cpumask_first(cpu_online_mask), &new_affinity); 239 + } 240 + irq_set_affinity_locked(d, &new_affinity, false); 241 + } 242 + 218 243 static int __init bcm7038_l1_init_one(struct device_node *dn, 219 244 unsigned int idx, 220 245 struct bcm7038_l1_chip *intc) ··· 291 266 .irq_mask = bcm7038_l1_mask, 292 267 .irq_unmask = bcm7038_l1_unmask, 293 268 .irq_set_affinity = bcm7038_l1_set_affinity, 269 + .irq_cpu_offline = bcm7038_l1_cpu_offline, 294 270 }; 295 271 296 272 static int bcm7038_l1_map(struct irq_domain *d, unsigned int virq,