USB: fix codingstyle issues in drivers/usb/core/hcd-pci.c

Fixes a number of coding style issues in the hcd-pci.c file.

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

+67 -62
+67 -62
drivers/usb/core/hcd-pci.c
··· 1 1 /* 2 2 * (C) Copyright David Brownell 2000-2002 3 - * 3 + * 4 4 * This program is free software; you can redistribute it and/or modify it 5 5 * under the terms of the GNU General Public License as published by the 6 6 * Free Software Foundation; either version 2 of the License, or (at your ··· 55 55 * 56 56 * Store this function in the HCD's struct pci_driver as probe(). 57 57 */ 58 - int usb_hcd_pci_probe (struct pci_dev *dev, const struct pci_device_id *id) 58 + int usb_hcd_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) 59 59 { 60 60 struct hc_driver *driver; 61 61 struct usb_hcd *hcd; ··· 64 64 if (usb_disabled()) 65 65 return -ENODEV; 66 66 67 - if (!id || !(driver = (struct hc_driver *) id->driver_data)) 67 + if (!id) 68 + return -EINVAL; 69 + driver = (struct hc_driver *)id->driver_data; 70 + if (!driver) 68 71 return -EINVAL; 69 72 70 - if (pci_enable_device (dev) < 0) 73 + if (pci_enable_device(dev) < 0) 71 74 return -ENODEV; 72 75 dev->current_state = PCI_D0; 73 76 dev->dev.power.power_state = PMSG_ON; 74 - 75 - if (!dev->irq) { 76 - dev_err (&dev->dev, 77 + 78 + if (!dev->irq) { 79 + dev_err(&dev->dev, 77 80 "Found HC with no IRQ. Check BIOS/PCI %s setup!\n", 78 81 pci_name(dev)); 79 - retval = -ENODEV; 82 + retval = -ENODEV; 80 83 goto err1; 81 - } 84 + } 82 85 83 - hcd = usb_create_hcd (driver, &dev->dev, pci_name(dev)); 86 + hcd = usb_create_hcd(driver, &dev->dev, pci_name(dev)); 84 87 if (!hcd) { 85 88 retval = -ENOMEM; 86 89 goto err1; 87 90 } 88 91 89 - if (driver->flags & HCD_MEMORY) { // EHCI, OHCI 90 - hcd->rsrc_start = pci_resource_start (dev, 0); 91 - hcd->rsrc_len = pci_resource_len (dev, 0); 92 - if (!request_mem_region (hcd->rsrc_start, hcd->rsrc_len, 92 + if (driver->flags & HCD_MEMORY) { 93 + /* EHCI, OHCI */ 94 + hcd->rsrc_start = pci_resource_start(dev, 0); 95 + hcd->rsrc_len = pci_resource_len(dev, 0); 96 + if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len, 93 97 driver->description)) { 94 - dev_dbg (&dev->dev, "controller already in use\n"); 98 + dev_dbg(&dev->dev, "controller already in use\n"); 95 99 retval = -EBUSY; 96 100 goto err2; 97 101 } 98 - hcd->regs = ioremap_nocache (hcd->rsrc_start, hcd->rsrc_len); 102 + hcd->regs = ioremap_nocache(hcd->rsrc_start, hcd->rsrc_len); 99 103 if (hcd->regs == NULL) { 100 - dev_dbg (&dev->dev, "error mapping memory\n"); 104 + dev_dbg(&dev->dev, "error mapping memory\n"); 101 105 retval = -EFAULT; 102 106 goto err3; 103 107 } 104 108 105 - } else { // UHCI 109 + } else { 110 + /* UHCI */ 106 111 int region; 107 112 108 113 for (region = 0; region < PCI_ROM_RESOURCE; region++) { 109 - if (!(pci_resource_flags (dev, region) & 114 + if (!(pci_resource_flags(dev, region) & 110 115 IORESOURCE_IO)) 111 116 continue; 112 117 113 - hcd->rsrc_start = pci_resource_start (dev, region); 114 - hcd->rsrc_len = pci_resource_len (dev, region); 115 - if (request_region (hcd->rsrc_start, hcd->rsrc_len, 118 + hcd->rsrc_start = pci_resource_start(dev, region); 119 + hcd->rsrc_len = pci_resource_len(dev, region); 120 + if (request_region(hcd->rsrc_start, hcd->rsrc_len, 116 121 driver->description)) 117 122 break; 118 123 } 119 124 if (region == PCI_ROM_RESOURCE) { 120 - dev_dbg (&dev->dev, "no i/o regions available\n"); 125 + dev_dbg(&dev->dev, "no i/o regions available\n"); 121 126 retval = -EBUSY; 122 127 goto err1; 123 128 } 124 129 } 125 130 126 - pci_set_master (dev); 131 + pci_set_master(dev); 127 132 128 133 retval = usb_add_hcd(hcd, dev->irq, IRQF_DISABLED | IRQF_SHARED); 129 134 if (retval != 0) ··· 137 132 138 133 err4: 139 134 if (driver->flags & HCD_MEMORY) { 140 - iounmap (hcd->regs); 135 + iounmap(hcd->regs); 141 136 err3: 142 - release_mem_region (hcd->rsrc_start, hcd->rsrc_len); 137 + release_mem_region(hcd->rsrc_start, hcd->rsrc_len); 143 138 } else 144 - release_region (hcd->rsrc_start, hcd->rsrc_len); 139 + release_region(hcd->rsrc_start, hcd->rsrc_len); 145 140 err2: 146 - usb_put_hcd (hcd); 141 + usb_put_hcd(hcd); 147 142 err1: 148 - pci_disable_device (dev); 149 - dev_err (&dev->dev, "init %s fail, %d\n", pci_name(dev), retval); 143 + pci_disable_device(dev); 144 + dev_err(&dev->dev, "init %s fail, %d\n", pci_name(dev), retval); 150 145 return retval; 151 - } 146 + } 152 147 EXPORT_SYMBOL_GPL(usb_hcd_pci_probe); 153 148 154 149 ··· 166 161 * 167 162 * Store this function in the HCD's struct pci_driver as remove(). 168 163 */ 169 - void usb_hcd_pci_remove (struct pci_dev *dev) 164 + void usb_hcd_pci_remove(struct pci_dev *dev) 170 165 { 171 166 struct usb_hcd *hcd; 172 167 ··· 174 169 if (!hcd) 175 170 return; 176 171 177 - usb_remove_hcd (hcd); 172 + usb_remove_hcd(hcd); 178 173 if (hcd->driver->flags & HCD_MEMORY) { 179 - iounmap (hcd->regs); 180 - release_mem_region (hcd->rsrc_start, hcd->rsrc_len); 174 + iounmap(hcd->regs); 175 + release_mem_region(hcd->rsrc_start, hcd->rsrc_len); 181 176 } else { 182 - release_region (hcd->rsrc_start, hcd->rsrc_len); 177 + release_region(hcd->rsrc_start, hcd->rsrc_len); 183 178 } 184 - usb_put_hcd (hcd); 179 + usb_put_hcd(hcd); 185 180 pci_disable_device(dev); 186 181 } 187 182 EXPORT_SYMBOL_GPL(usb_hcd_pci_remove); ··· 196 191 * 197 192 * Store this function in the HCD's struct pci_driver as suspend(). 198 193 */ 199 - int usb_hcd_pci_suspend (struct pci_dev *dev, pm_message_t message) 194 + int usb_hcd_pci_suspend(struct pci_dev *dev, pm_message_t message) 200 195 { 201 196 struct usb_hcd *hcd; 202 197 int retval = 0; ··· 251 246 252 247 /* no DMA or IRQs except when HC is active */ 253 248 if (dev->current_state == PCI_D0) { 254 - pci_save_state (dev); 255 - pci_disable_device (dev); 249 + pci_save_state(dev); 250 + pci_disable_device(dev); 256 251 } 257 252 258 253 if (message.event == PM_EVENT_FREEZE || ··· 262 257 } 263 258 264 259 if (!has_pci_pm) { 265 - dev_dbg (hcd->self.controller, "--> PCI D0/legacy\n"); 260 + dev_dbg(hcd->self.controller, "--> PCI D0/legacy\n"); 266 261 goto done; 267 262 } 268 263 ··· 271 266 * PCI_D3 (but not PCI_D1 or PCI_D2) is allowed to reset 272 267 * some device state (e.g. as part of clock reinit). 273 268 */ 274 - retval = pci_set_power_state (dev, PCI_D3hot); 269 + retval = pci_set_power_state(dev, PCI_D3hot); 275 270 suspend_report_result(pci_set_power_state, retval); 276 271 if (retval == 0) { 277 272 int wake = device_can_wakeup(&hcd->self.root_hub->dev); 278 273 279 274 wake = wake && device_may_wakeup(hcd->self.controller); 280 275 281 - dev_dbg (hcd->self.controller, "--> PCI D3%s\n", 276 + dev_dbg(hcd->self.controller, "--> PCI D3%s\n", 282 277 wake ? "/wakeup" : ""); 283 278 284 279 /* Ignore these return values. We rely on pci code to 285 280 * reject requests the hardware can't implement, rather 286 281 * than coding the same thing. 287 282 */ 288 - (void) pci_enable_wake (dev, PCI_D3hot, wake); 289 - (void) pci_enable_wake (dev, PCI_D3cold, wake); 283 + (void) pci_enable_wake(dev, PCI_D3hot, wake); 284 + (void) pci_enable_wake(dev, PCI_D3cold, wake); 290 285 } else { 291 - dev_dbg (&dev->dev, "PCI D3 suspend fail, %d\n", 286 + dev_dbg(&dev->dev, "PCI D3 suspend fail, %d\n", 292 287 retval); 293 - (void) usb_hcd_pci_resume (dev); 288 + (void) usb_hcd_pci_resume(dev); 294 289 } 295 290 296 291 } else if (hcd->state != HC_STATE_HALT) { 297 - dev_dbg (hcd->self.controller, "hcd state %d; not suspended\n", 292 + dev_dbg(hcd->self.controller, "hcd state %d; not suspended\n", 298 293 hcd->state); 299 294 WARN_ON(1); 300 295 retval = -EINVAL; ··· 309 304 if (machine_is(powermac)) { 310 305 struct device_node *of_node; 311 306 312 - of_node = pci_device_to_OF_node (dev); 307 + of_node = pci_device_to_OF_node(dev); 313 308 if (of_node) 314 309 pmac_call_feature(PMAC_FTR_USB_ENABLE, 315 310 of_node, 0, 0); ··· 327 322 * 328 323 * Store this function in the HCD's struct pci_driver as resume(). 329 324 */ 330 - int usb_hcd_pci_resume (struct pci_dev *dev) 325 + int usb_hcd_pci_resume(struct pci_dev *dev) 331 326 { 332 327 struct usb_hcd *hcd; 333 328 int retval; 334 329 335 330 hcd = pci_get_drvdata(dev); 336 331 if (hcd->state != HC_STATE_SUSPENDED) { 337 - dev_dbg (hcd->self.controller, 332 + dev_dbg(hcd->self.controller, 338 333 "can't resume, not suspended!\n"); 339 334 return 0; 340 335 } ··· 344 339 if (machine_is(powermac)) { 345 340 struct device_node *of_node; 346 341 347 - of_node = pci_device_to_OF_node (dev); 342 + of_node = pci_device_to_OF_node(dev); 348 343 if (of_node) 349 - pmac_call_feature (PMAC_FTR_USB_ENABLE, 344 + pmac_call_feature(PMAC_FTR_USB_ENABLE, 350 345 of_node, 0, 1); 351 346 } 352 347 #endif ··· 385 380 } 386 381 #endif 387 382 /* yes, ignore these results too... */ 388 - (void) pci_enable_wake (dev, dev->current_state, 0); 389 - (void) pci_enable_wake (dev, PCI_D3cold, 0); 383 + (void) pci_enable_wake(dev, dev->current_state, 0); 384 + (void) pci_enable_wake(dev, PCI_D3cold, 0); 390 385 } else { 391 386 /* Same basic cases: clean (powered/not), dirty */ 392 387 dev_dbg(hcd->self.controller, "PCI legacy resume\n"); ··· 397 392 * but that won't re-enable bus mastering. Yet pci_disable_device() 398 393 * explicitly disables bus mastering... 399 394 */ 400 - retval = pci_enable_device (dev); 395 + retval = pci_enable_device(dev); 401 396 if (retval < 0) { 402 - dev_err (hcd->self.controller, 397 + dev_err(hcd->self.controller, 403 398 "can't re-enable after resume, %d!\n", retval); 404 399 return retval; 405 400 } 406 - pci_set_master (dev); 407 - pci_restore_state (dev); 401 + pci_set_master(dev); 402 + pci_restore_state(dev); 408 403 409 404 dev->dev.power.power_state = PMSG_ON; 410 405 ··· 413 408 if (hcd->driver->resume) { 414 409 retval = hcd->driver->resume(hcd); 415 410 if (retval) { 416 - dev_err (hcd->self.controller, 411 + dev_err(hcd->self.controller, 417 412 "PCI post-resume error %d!\n", retval); 418 - usb_hc_died (hcd); 413 + usb_hc_died(hcd); 419 414 } 420 415 } 421 416 ··· 429 424 * usb_hcd_pci_shutdown - shutdown host controller 430 425 * @dev: USB Host Controller being shutdown 431 426 */ 432 - void usb_hcd_pci_shutdown (struct pci_dev *dev) 427 + void usb_hcd_pci_shutdown(struct pci_dev *dev) 433 428 { 434 429 struct usb_hcd *hcd; 435 430