Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

clk: qoriq: add __init attribute

Add __init attribute on a function that is only called from other __init
functions and that is not inlined, at least with gcc version 4.8.4 on an
x86 machine with allyesconfig. Currently, the function is put in the
.text.unlikely segment. Declaring it as __init will cause it to be put in
the .init.text and to disappear after initialization.

The result of objdump -x on the function before the change is as follows:

0000000000000000 l F .text.unlikely 0000000000000071 sysclk_from_fixed.constprop.5

And after the change it is as follows:

0000000000000480 l F .init.text 000000000000006c sysclk_from_fixed.constprop.5

Done with the help of Coccinelle. The semantic patch checks for local
static non-init functions that are called from an __init function and are
not called from any other function.

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>

authored by

Julia Lawall and committed by
Stephen Boyd
3432a2e3 660e1551

+2 -1
+2 -1
drivers/clk/clk-qoriq.c
··· 869 869 } 870 870 } 871 871 872 - static struct clk *sysclk_from_fixed(struct device_node *node, const char *name) 872 + static struct clk __init 873 + *sysclk_from_fixed(struct device_node *node, const char *name) 873 874 { 874 875 u32 rate; 875 876