Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

powerpc/cell/iommu: Improve error message for missing node

Some devices don't have a correct node ID and thus can't be
attached to an iommu.

The message displayed by the iommu code isn't very useful if
you don't have a device-tree node as it tries to print the
device-tree path but not the struct device name.

Improve this by printing the device name as well.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

+1 -1
+1 -1
arch/powerpc/platforms/cell/iommu.c
··· 550 550 */ 551 551 iommu = cell_iommu_for_node(dev_to_node(dev)); 552 552 if (iommu == NULL || list_empty(&iommu->windows)) { 553 - printk(KERN_ERR "iommu: missing iommu for %s (node %d)\n", 553 + dev_err(dev, "iommu: missing iommu for %s (node %d)\n", 554 554 of_node_full_name(dev->of_node), dev_to_node(dev)); 555 555 return NULL; 556 556 }