Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: dsa: qca8k: fix LEDS_CLASS dependency

With LEDS_CLASS=m, a built-in qca8k driver fails to link:

arm-linux-gnueabi-ld: drivers/net/dsa/qca/qca8k-leds.o: in function `qca8k_setup_led_ctrl':
qca8k-leds.c:(.text+0x1ea): undefined reference to `devm_led_classdev_register_ext'

Change the dependency to avoid the broken configuration.

Fixes: 1e264f9d2918 ("net: dsa: qca8k: add LEDs basic support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230420213639.2243388-1-arnd@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Arnd Bergmann and committed by
Jakub Kicinski
33c1af8e 6aa445e3

+1 -1
+1 -1
drivers/net/dsa/qca/Kconfig
··· 19 19 config NET_DSA_QCA8K_LEDS_SUPPORT 20 20 bool "Qualcomm Atheros QCA8K Ethernet switch family LEDs support" 21 21 depends on NET_DSA_QCA8K 22 - depends on LEDS_CLASS 22 + depends on LEDS_CLASS=y || LEDS_CLASS=NET_DSA_QCA8K 23 23 help 24 24 This enabled support for LEDs present on the Qualcomm Atheros 25 25 QCA8K Ethernet switch chips.