Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Input: sx8643 - simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20230625162817.100397-22-krzysztof.kozlowski@linaro.org
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

authored by

Krzysztof Kozlowski and committed by
Dmitry Torokhov
337ac36c d08149c1

+3 -7
+3 -7
drivers/input/touchscreen/sx8654.c
··· 323 323 324 324 sx8654->gpio_reset = devm_gpiod_get_optional(&client->dev, "reset", 325 325 GPIOD_OUT_HIGH); 326 - if (IS_ERR(sx8654->gpio_reset)) { 327 - error = PTR_ERR(sx8654->gpio_reset); 328 - if (error != -EPROBE_DEFER) 329 - dev_err(&client->dev, "unable to get reset-gpio: %d\n", 330 - error); 331 - return error; 332 - } 326 + if (IS_ERR(sx8654->gpio_reset)) 327 + return dev_err_probe(&client->dev, PTR_ERR(sx8654->gpio_reset), 328 + "unable to get reset-gpio\n"); 333 329 dev_dbg(&client->dev, "got GPIO reset pin\n"); 334 330 335 331 sx8654->data = device_get_match_data(&client->dev);