Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drivers/vlynq/vlynq.c: fix resource size off by 1 error

In this case, the calls to request_mem_region, ioremap, and
release_mem_region all have a consistent length argument, len, but since
in other files (res->end - res->start) + 1, equivalent to
resource_size(res), is used for a resource-typed structure res, one could
consider whether the same should be done here.

The problem was found using the following semantic patch:
(http://www.emn.fr/x-info/coccinelle/)

// <smpl>
@@
struct resource *res;
@@

- (res->end - res->start) + 1
+ resource_size(res)

@@
struct resource *res;
@@

- res->end - res->start
+ BAD(resource_size(res))
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Florian Fainelli <florian@openwrt.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Julia Lawall and committed by
Linus Torvalds
3354f73b a21f3c2a

+1 -1
+1 -1
drivers/vlynq/vlynq.c
··· 702 702 dev->mem_start = mem_res->start; 703 703 dev->mem_end = mem_res->end; 704 704 705 - len = regs_res->end - regs_res->start; 705 + len = resource_size(regs_res); 706 706 if (!request_mem_region(regs_res->start, len, dev_name(&dev->dev))) { 707 707 printk(KERN_ERR "%s: Can't request vlynq registers\n", 708 708 dev_name(&dev->dev));