Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

scsi: aacraid: Fix undefined behavior due to shift overflowing the constant

Fix:

drivers/scsi/aacraid/commsup.c: In function ‘aac_handle_sa_aif’:
drivers/scsi/aacraid/commsup.c:1983:2: error: case label does not reduce to an integer constant
case SA_AIF_BPCFG_CHANGE:
^~~~

See https://lore.kernel.org/r/YkwQ6%2BtIH8GQpuct@zn.tnic for the gory
details as to why it triggers with older gccs only.

Link: https://lore.kernel.org/r/20220405151517.29753-2-bp@alien8.de
Cc: Adaptec OEM Raid Solutions <aacraid@microsemi.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>
Cc: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: linux-scsi@vger.kernel.org
Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Borislav Petkov <bp@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

authored by

Borislav Petkov and committed by
Martin K. Petersen
331c6e91 4a5fc1c6

+1 -1
+1 -1
drivers/scsi/aacraid/aacraid.h
··· 121 121 #define SA_AIF_PDEV_CHANGE (1<<4) 122 122 #define SA_AIF_LDEV_CHANGE (1<<5) 123 123 #define SA_AIF_BPSTAT_CHANGE (1<<30) 124 - #define SA_AIF_BPCFG_CHANGE (1<<31) 124 + #define SA_AIF_BPCFG_CHANGE (1U<<31) 125 125 126 126 #define HBA_MAX_SG_EMBEDDED 28 127 127 #define HBA_MAX_SG_SEPARATE 90