Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

[media] tveeprom: remove v4l2-chip-ident.h include

Replace the V4L2_IDENT_* usage with tveeprom-specific defines. This header
is deprecated, so those defines shouldn't be used anymore.
The em28xx driver is the only one that uses the tveeprom audio_processor
field, so that has been updated to use the new tveeprom AUDPROC define.

Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

authored by

Hans Verkuil and committed by
Mauro Carvalho Chehab
33001010 7486af1a

+78 -78
+66 -76
drivers/media/common/tveeprom.c
··· 40 40 #include <media/tuner.h> 41 41 #include <media/tveeprom.h> 42 42 #include <media/v4l2-common.h> 43 - #include <media/v4l2-chip-ident.h> 44 43 45 44 MODULE_DESCRIPTION("i2c Hauppauge eeprom decoder driver"); 46 45 MODULE_AUTHOR("John Klar"); ··· 66 67 * The Hauppauge eeprom uses an 8bit field to determine which 67 68 * tuner formats the tuner supports. 68 69 */ 69 - static struct HAUPPAUGE_TUNER_FMT 70 - { 70 + static const struct { 71 71 int id; 72 - char *name; 73 - } 74 - hauppauge_tuner_fmt[] = 75 - { 72 + const char * const name; 73 + } hauppauge_tuner_fmt[] = { 76 74 { V4L2_STD_UNKNOWN, " UNKNOWN" }, 77 75 { V4L2_STD_UNKNOWN, " FM" }, 78 76 { V4L2_STD_B|V4L2_STD_GH, " PAL(B/G)" }, ··· 84 88 supplying this information. Note that many tuners where only used for 85 89 testing and never made it to the outside world. So you will only see 86 90 a subset in actual produced cards. */ 87 - static struct HAUPPAUGE_TUNER 88 - { 91 + static const struct { 89 92 int id; 90 - char *name; 91 - } 92 - hauppauge_tuner[] = 93 - { 93 + const char * const name; 94 + } hauppauge_tuner[] = { 94 95 /* 0-9 */ 95 96 { TUNER_ABSENT, "None" }, 96 97 { TUNER_ABSENT, "External" }, ··· 291 298 { TUNER_ABSENT, "NXP 18272S"}, 292 299 }; 293 300 294 - /* Use V4L2_IDENT_AMBIGUOUS for those audio 'chips' that are 301 + /* Use TVEEPROM_AUDPROC_INTERNAL for those audio 'chips' that are 295 302 * internal to a video chip, i.e. not a separate audio chip. */ 296 - static struct HAUPPAUGE_AUDIOIC 297 - { 303 + static const struct { 298 304 u32 id; 299 - char *name; 300 - } 301 - audioIC[] = 302 - { 305 + const char * const name; 306 + } audio_ic[] = { 303 307 /* 0-4 */ 304 - { V4L2_IDENT_NONE, "None" }, 305 - { V4L2_IDENT_UNKNOWN, "TEA6300" }, 306 - { V4L2_IDENT_UNKNOWN, "TEA6320" }, 307 - { V4L2_IDENT_UNKNOWN, "TDA9850" }, 308 - { V4L2_IDENT_MSPX4XX, "MSP3400C" }, 308 + { TVEEPROM_AUDPROC_NONE, "None" }, 309 + { TVEEPROM_AUDPROC_OTHER, "TEA6300" }, 310 + { TVEEPROM_AUDPROC_OTHER, "TEA6320" }, 311 + { TVEEPROM_AUDPROC_OTHER, "TDA9850" }, 312 + { TVEEPROM_AUDPROC_MSP, "MSP3400C" }, 309 313 /* 5-9 */ 310 - { V4L2_IDENT_MSPX4XX, "MSP3410D" }, 311 - { V4L2_IDENT_MSPX4XX, "MSP3415" }, 312 - { V4L2_IDENT_MSPX4XX, "MSP3430" }, 313 - { V4L2_IDENT_MSPX4XX, "MSP3438" }, 314 - { V4L2_IDENT_UNKNOWN, "CS5331" }, 314 + { TVEEPROM_AUDPROC_MSP, "MSP3410D" }, 315 + { TVEEPROM_AUDPROC_MSP, "MSP3415" }, 316 + { TVEEPROM_AUDPROC_MSP, "MSP3430" }, 317 + { TVEEPROM_AUDPROC_MSP, "MSP3438" }, 318 + { TVEEPROM_AUDPROC_OTHER, "CS5331" }, 315 319 /* 10-14 */ 316 - { V4L2_IDENT_MSPX4XX, "MSP3435" }, 317 - { V4L2_IDENT_MSPX4XX, "MSP3440" }, 318 - { V4L2_IDENT_MSPX4XX, "MSP3445" }, 319 - { V4L2_IDENT_MSPX4XX, "MSP3411" }, 320 - { V4L2_IDENT_MSPX4XX, "MSP3416" }, 320 + { TVEEPROM_AUDPROC_MSP, "MSP3435" }, 321 + { TVEEPROM_AUDPROC_MSP, "MSP3440" }, 322 + { TVEEPROM_AUDPROC_MSP, "MSP3445" }, 323 + { TVEEPROM_AUDPROC_MSP, "MSP3411" }, 324 + { TVEEPROM_AUDPROC_MSP, "MSP3416" }, 321 325 /* 15-19 */ 322 - { V4L2_IDENT_MSPX4XX, "MSP3425" }, 323 - { V4L2_IDENT_MSPX4XX, "MSP3451" }, 324 - { V4L2_IDENT_MSPX4XX, "MSP3418" }, 325 - { V4L2_IDENT_UNKNOWN, "Type 0x12" }, 326 - { V4L2_IDENT_UNKNOWN, "OKI7716" }, 326 + { TVEEPROM_AUDPROC_MSP, "MSP3425" }, 327 + { TVEEPROM_AUDPROC_MSP, "MSP3451" }, 328 + { TVEEPROM_AUDPROC_MSP, "MSP3418" }, 329 + { TVEEPROM_AUDPROC_OTHER, "Type 0x12" }, 330 + { TVEEPROM_AUDPROC_OTHER, "OKI7716" }, 327 331 /* 20-24 */ 328 - { V4L2_IDENT_MSPX4XX, "MSP4410" }, 329 - { V4L2_IDENT_MSPX4XX, "MSP4420" }, 330 - { V4L2_IDENT_MSPX4XX, "MSP4440" }, 331 - { V4L2_IDENT_MSPX4XX, "MSP4450" }, 332 - { V4L2_IDENT_MSPX4XX, "MSP4408" }, 332 + { TVEEPROM_AUDPROC_MSP, "MSP4410" }, 333 + { TVEEPROM_AUDPROC_MSP, "MSP4420" }, 334 + { TVEEPROM_AUDPROC_MSP, "MSP4440" }, 335 + { TVEEPROM_AUDPROC_MSP, "MSP4450" }, 336 + { TVEEPROM_AUDPROC_MSP, "MSP4408" }, 333 337 /* 25-29 */ 334 - { V4L2_IDENT_MSPX4XX, "MSP4418" }, 335 - { V4L2_IDENT_MSPX4XX, "MSP4428" }, 336 - { V4L2_IDENT_MSPX4XX, "MSP4448" }, 337 - { V4L2_IDENT_MSPX4XX, "MSP4458" }, 338 - { V4L2_IDENT_MSPX4XX, "Type 0x1d" }, 338 + { TVEEPROM_AUDPROC_MSP, "MSP4418" }, 339 + { TVEEPROM_AUDPROC_MSP, "MSP4428" }, 340 + { TVEEPROM_AUDPROC_MSP, "MSP4448" }, 341 + { TVEEPROM_AUDPROC_MSP, "MSP4458" }, 342 + { TVEEPROM_AUDPROC_MSP, "Type 0x1d" }, 339 343 /* 30-34 */ 340 - { V4L2_IDENT_AMBIGUOUS, "CX880" }, 341 - { V4L2_IDENT_AMBIGUOUS, "CX881" }, 342 - { V4L2_IDENT_AMBIGUOUS, "CX883" }, 343 - { V4L2_IDENT_AMBIGUOUS, "CX882" }, 344 - { V4L2_IDENT_AMBIGUOUS, "CX25840" }, 344 + { TVEEPROM_AUDPROC_INTERNAL, "CX880" }, 345 + { TVEEPROM_AUDPROC_INTERNAL, "CX881" }, 346 + { TVEEPROM_AUDPROC_INTERNAL, "CX883" }, 347 + { TVEEPROM_AUDPROC_INTERNAL, "CX882" }, 348 + { TVEEPROM_AUDPROC_INTERNAL, "CX25840" }, 345 349 /* 35-39 */ 346 - { V4L2_IDENT_AMBIGUOUS, "CX25841" }, 347 - { V4L2_IDENT_AMBIGUOUS, "CX25842" }, 348 - { V4L2_IDENT_AMBIGUOUS, "CX25843" }, 349 - { V4L2_IDENT_AMBIGUOUS, "CX23418" }, 350 - { V4L2_IDENT_AMBIGUOUS, "CX23885" }, 350 + { TVEEPROM_AUDPROC_INTERNAL, "CX25841" }, 351 + { TVEEPROM_AUDPROC_INTERNAL, "CX25842" }, 352 + { TVEEPROM_AUDPROC_INTERNAL, "CX25843" }, 353 + { TVEEPROM_AUDPROC_INTERNAL, "CX23418" }, 354 + { TVEEPROM_AUDPROC_INTERNAL, "CX23885" }, 351 355 /* 40-44 */ 352 - { V4L2_IDENT_AMBIGUOUS, "CX23888" }, 353 - { V4L2_IDENT_AMBIGUOUS, "SAA7131" }, 354 - { V4L2_IDENT_AMBIGUOUS, "CX23887" }, 355 - { V4L2_IDENT_AMBIGUOUS, "SAA7164" }, 356 - { V4L2_IDENT_AMBIGUOUS, "AU8522" }, 356 + { TVEEPROM_AUDPROC_INTERNAL, "CX23888" }, 357 + { TVEEPROM_AUDPROC_INTERNAL, "SAA7131" }, 358 + { TVEEPROM_AUDPROC_INTERNAL, "CX23887" }, 359 + { TVEEPROM_AUDPROC_INTERNAL, "SAA7164" }, 360 + { TVEEPROM_AUDPROC_INTERNAL, "AU8522" }, 357 361 }; 358 362 359 363 /* This list is supplied by Hauppauge. Thanks! */ ··· 443 453 int i, j, len, done, beenhere, tag, start; 444 454 445 455 int tuner1 = 0, t_format1 = 0, audioic = -1; 446 - char *t_name1 = NULL; 456 + const char *t_name1 = NULL; 447 457 const char *t_fmt_name1[8] = { " none", "", "", "", "", "", "", "" }; 448 458 449 459 int tuner2 = 0, t_format2 = 0; 450 - char *t_name2 = NULL; 460 + const char *t_name2 = NULL; 451 461 const char *t_fmt_name2[8] = { " none", "", "", "", "", "", "", "" }; 452 462 453 463 memset(tvee, 0, sizeof(*tvee)); ··· 535 545 to indicate 4052 mux was removed in favor of using MSP 536 546 inputs directly. */ 537 547 audioic = eeprom_data[i+2] & 0x7f; 538 - if (audioic < ARRAY_SIZE(audioIC)) 539 - tvee->audio_processor = audioIC[audioic].id; 548 + if (audioic < ARRAY_SIZE(audio_ic)) 549 + tvee->audio_processor = audio_ic[audioic].id; 540 550 else 541 - tvee->audio_processor = V4L2_IDENT_UNKNOWN; 551 + tvee->audio_processor = TVEEPROM_AUDPROC_OTHER; 542 552 break; 543 553 544 554 /* case 0x03: tag 'EEInfo' */ ··· 568 578 to indicate 4052 mux was removed in favor of using MSP 569 579 inputs directly. */ 570 580 audioic = eeprom_data[i+1] & 0x7f; 571 - if (audioic < ARRAY_SIZE(audioIC)) 572 - tvee->audio_processor = audioIC[audioic].id; 581 + if (audioic < ARRAY_SIZE(audio_ic)) 582 + tvee->audio_processor = audio_ic[audioic].id; 573 583 else 574 - tvee->audio_processor = V4L2_IDENT_UNKNOWN; 584 + tvee->audio_processor = TVEEPROM_AUDPROC_OTHER; 575 585 576 586 break; 577 587 ··· 716 726 t_fmt_name2[6], t_fmt_name2[7], t_format2); 717 727 if (audioic < 0) { 718 728 tveeprom_info("audio processor is unknown (no idx)\n"); 719 - tvee->audio_processor = V4L2_IDENT_UNKNOWN; 729 + tvee->audio_processor = TVEEPROM_AUDPROC_OTHER; 720 730 } else { 721 - if (audioic < ARRAY_SIZE(audioIC)) 731 + if (audioic < ARRAY_SIZE(audio_ic)) 722 732 tveeprom_info("audio processor is %s (idx %d)\n", 723 - audioIC[audioic].name, audioic); 733 + audio_ic[audioic].name, audioic); 724 734 else 725 735 tveeprom_info("audio processor is unknown (idx %d)\n", 726 736 audioic);
+1 -2
drivers/media/usb/em28xx/em28xx-cards.c
··· 37 37 #include <media/i2c-addr.h> 38 38 #include <media/tveeprom.h> 39 39 #include <media/v4l2-common.h> 40 - #include <media/v4l2-chip-ident.h> 41 40 42 41 #include "em28xx.h" 43 42 ··· 2668 2669 2669 2670 dev->tuner_type = tv.tuner_type; 2670 2671 2671 - if (tv.audio_processor == V4L2_IDENT_MSPX4XX) { 2672 + if (tv.audio_processor == TVEEPROM_AUDPROC_MSP) { 2672 2673 dev->i2s_speed = 2048000; 2673 2674 dev->board.has_msp34xx = 1; 2674 2675 }
+11
include/media/tveeprom.h
··· 1 1 /* 2 2 */ 3 3 4 + enum tveeprom_audio_processor { 5 + /* No audio processor present */ 6 + TVEEPROM_AUDPROC_NONE, 7 + /* The audio processor is internal to the video processor */ 8 + TVEEPROM_AUDPROC_INTERNAL, 9 + /* The audio processor is a MSPXXXX device */ 10 + TVEEPROM_AUDPROC_MSP, 11 + /* The audio processor is another device */ 12 + TVEEPROM_AUDPROC_OTHER, 13 + }; 14 + 4 15 struct tveeprom { 5 16 u32 has_radio; 6 17 /* If has_ir == 0, then it is unknown what the IR capabilities are,