Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: phy: fix phy_read_poll_timeout argument type in genphy_loopback

read_poll_timeout inside phy_read_poll_timeout can set val negative
in some cases (for example, __mdiobus_read inside phy_read can return
-EOPNOTSUPP).

Supposedly, commit 4ec732951702 ("net: phylib: fix phy_read*_poll_timeout()")
should fix problems with wrong-signed vals, but I do not see how
as val is sent to phy_read as is and __val = phy_read (not val)
is checked for sign.

Change val type for signed to allow better error handling as done in other
phy_read_poll_timeout callers. This will not fix any error handling
by itself, but allows, for example, to modify cond with appropriate
sign check or check resulting val separately.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 014068dcb5b1 ("net: phy: genphy_loopback: add link speed configuration")
Signed-off-by: Nikita Kiryushin <kiryushin@ancud.ru>
Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Link: https://lore.kernel.org/r/20240315175052.8049-1-kiryushin@ancud.ru
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Nikita Kiryushin and committed by
Paolo Abeni
32fa4366 9474c62a

+2 -2
+2 -2
drivers/net/phy/phy_device.c
··· 2831 2831 int genphy_loopback(struct phy_device *phydev, bool enable) 2832 2832 { 2833 2833 if (enable) { 2834 - u16 val, ctl = BMCR_LOOPBACK; 2835 - int ret; 2834 + u16 ctl = BMCR_LOOPBACK; 2835 + int ret, val; 2836 2836 2837 2837 ctl |= mii_bmcr_encode_fixed(phydev->speed, phydev->duplex); 2838 2838