Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

DRM: UDL: get rid of useless vblank initialization

UDL doesn't support vblank functionality so we don't need to
initialize vblank here (we are able to send page flip
completion events even without vblank initialization)

Moreover current drm_vblank_init call with num_crtcs > 0 causes
sending DRM_EVENT_FLIP_COMPLETE event with zero timestamp every
time. This breaks userspace apps (for example weston) which
relies on timestamp value.

Cc: stable@vger.kernel.org
Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20180928144126.21598-1-Eugeniy.Paltsev@synopsys.com

authored by

Eugeniy Paltsev and committed by
Daniel Vetter
32e932e3 8dc830e4

+1 -6
+1 -6
drivers/gpu/drm/udl/udl_main.c
··· 350 350 if (ret) 351 351 goto err; 352 352 353 - ret = drm_vblank_init(dev, 1); 354 - if (ret) 355 - goto err_fb; 356 - 357 353 drm_kms_helper_poll_init(dev); 358 354 359 355 return 0; 360 - err_fb: 361 - udl_fbdev_cleanup(dev); 356 + 362 357 err: 363 358 if (udl->urbs.count) 364 359 udl_free_urb_list(dev);