Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: rtnl: introduce rcu_replace_pointer_rtnl

Introduce the rcu_replace_pointer_rtnl helper to lockdep check rtnl lock
rcu replacements, alongside the already existing helpers.

This is a quality of life helper so instead of using:
rcu_replace_pointer(rp, p, lockdep_rtnl_is_held())
.. or the open coded..
rtnl_dereference() / rcu_assign_pointer()
.. or the lazy check version ..
rcu_replace_pointer(rp, p, 1)
Use:
rcu_replace_pointer_rtnl(rp, p)

Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Signed-off-by: Pedro Tammela <pctammela@mojatatu.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Jamal Hadi Salim and committed by
David S. Miller
32da0f00 54f4c257

+12
+12
include/linux/rtnetlink.h
··· 79 79 #define rtnl_dereference(p) \ 80 80 rcu_dereference_protected(p, lockdep_rtnl_is_held()) 81 81 82 + /** 83 + * rcu_replace_pointer_rtnl - replace an RCU pointer under rtnl_lock, returning 84 + * its old value 85 + * @rp: RCU pointer, whose value is returned 86 + * @p: regular pointer 87 + * 88 + * Perform a replacement under rtnl_lock, where @rp is an RCU-annotated 89 + * pointer. The old value of @rp is returned, and @rp is set to @p 90 + */ 91 + #define rcu_replace_pointer_rtnl(rp, p) \ 92 + rcu_replace_pointer(rp, p, lockdep_rtnl_is_held()) 93 + 82 94 static inline struct netdev_queue *dev_ingress_queue(struct net_device *dev) 83 95 { 84 96 return rtnl_dereference(dev->ingress_queue);