Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: picoxcell - Use devm_ioremap_resource()

Use devm_ioremap_resource() in order to make the code simpler,
and remove redundant return value check of platform_get_resource()
because the value is checked by devm_ioremap_resource().

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Jingoo Han and committed by
Herbert Xu
32af1e18 06e5a1f2

+5 -11
+5 -11
drivers/crypto/picoxcell_crypto.c
··· 1720 1720 engine->name = dev_name(&pdev->dev); 1721 1721 1722 1722 mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); 1723 + engine->regs = devm_ioremap_resource(&pdev->dev, mem); 1724 + if (IS_ERR(engine->regs)) 1725 + return PTR_ERR(engine->regs); 1726 + 1723 1727 irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); 1724 - if (!mem || !irq) { 1728 + if (!irq) { 1725 1729 dev_err(&pdev->dev, "no memory/irq resource for engine\n"); 1726 1730 return -ENXIO; 1727 - } 1728 - 1729 - if (!devm_request_mem_region(&pdev->dev, mem->start, resource_size(mem), 1730 - engine->name)) 1731 - return -ENOMEM; 1732 - 1733 - engine->regs = devm_ioremap(&pdev->dev, mem->start, resource_size(mem)); 1734 - if (!engine->regs) { 1735 - dev_err(&pdev->dev, "memory map failed\n"); 1736 - return -ENOMEM; 1737 1731 } 1738 1732 1739 1733 if (devm_request_irq(&pdev->dev, irq->start, spacc_spacc_irq, 0,