tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

tg3: Remove unused PHY_BRCM flags

The tg3 driver tried to communicate towards the PHY driver whether it
wanted RGMII in-band signaling enabled or disabled however there is
nothing that looks at those flags in drivers/net/phy/broadcom.c so this
does do not anything.

Suggested-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Florian Fainelli and committed by
David S. Miller 32aeba1f 2928de97

+3 -12
-6
drivers/net/ethernet/broadcom/tg3.c
··· 1580 1580 PHY_BRCM_RX_REFCLK_UNUSED | 1581 1581 PHY_BRCM_DIS_TXCRXC_NOENRGY | 1582 1582 PHY_BRCM_AUTO_PWRDWN_ENABLE; 1583 - if (tg3_flag(tp, RGMII_INBAND_DISABLE)) 1584 - phydev->dev_flags |= PHY_BRCM_STD_IBND_DISABLE; 1585 - if (tg3_flag(tp, RGMII_EXT_IBND_RX_EN)) 1586 - phydev->dev_flags |= PHY_BRCM_EXT_IBND_RX_ENABLE; 1587 - if (tg3_flag(tp, RGMII_EXT_IBND_TX_EN)) 1588 - phydev->dev_flags |= PHY_BRCM_EXT_IBND_TX_ENABLE; 1589 1583 fallthrough; 1590 1584 case PHY_ID_RTL8211C: 1591 1585 phydev->interface = PHY_INTERFACE_MODE_RGMII;
+3 -6
include/linux/brcmphy.h
··· 63 63 64 64 #define PHY_BRCM_AUTO_PWRDWN_ENABLE 0x00000001 65 65 #define PHY_BRCM_RX_REFCLK_UNUSED 0x00000002 66 - #define PHY_BRCM_STD_IBND_DISABLE 0x00000004 67 - #define PHY_BRCM_EXT_IBND_RX_ENABLE 0x00000008 68 - #define PHY_BRCM_EXT_IBND_TX_ENABLE 0x00000010 69 - #define PHY_BRCM_CLEAR_RGMII_MODE 0x00000020 70 - #define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00000040 71 - #define PHY_BRCM_EN_MASTER_MODE 0x00000080 66 + #define PHY_BRCM_CLEAR_RGMII_MODE 0x00000004 67 + #define PHY_BRCM_DIS_TXCRXC_NOENRGY 0x00000008 68 + #define PHY_BRCM_EN_MASTER_MODE 0x00000010 72 69 73 70 /* Broadcom BCM7xxx specific workarounds */ 74 71 #define PHY_BRCM_7XXX_REV(x) (((x) >> 8) & 0xff)