Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fscache: Use clear_and_wake_up_bit() in fscache_create_volume_work()

fscache_create_volume_work() uses wake_up_bit() to wake up the processes
which are waiting for the completion of volume creation. According to
comments in wake_up_bit() and waitqueue_active(), an extra smp_mb() is
needed to guarantee the memory order between FSCACHE_VOLUME_CREATING
flag and waitqueue_active() before invoking wake_up_bit().

Fixing it by using clear_and_wake_up_bit() to add the missing memory
barrier.

Reviewed-by: Jingbo Xu <jefflexu@linux.alibaba.com>
Signed-off-by: Hou Tao <houtao1@huawei.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Link: https://lore.kernel.org/r/20230113115211.2895845-3-houtao@huaweicloud.com/ # v3

authored by

Hou Tao and committed by
David Howells
3288666c 8226e37d

+1 -2
+1 -2
fs/fscache/volume.c
··· 280 280 fscache_end_cache_access(volume->cache, 281 281 fscache_access_acquire_volume_end); 282 282 283 - clear_bit_unlock(FSCACHE_VOLUME_CREATING, &volume->flags); 284 - wake_up_bit(&volume->flags, FSCACHE_VOLUME_CREATING); 283 + clear_and_wake_up_bit(FSCACHE_VOLUME_CREATING, &volume->flags); 285 284 fscache_put_volume(volume, fscache_volume_put_create_work); 286 285 } 287 286