Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ALSA: pxa2xx: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-4-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
3210e62a 9ac0d69e

+2 -4
+2 -4
sound/arm/pxa2xx-ac97.c
··· 262 262 return ret; 263 263 } 264 264 265 - static int pxa2xx_ac97_remove(struct platform_device *dev) 265 + static void pxa2xx_ac97_remove(struct platform_device *dev) 266 266 { 267 267 struct snd_card *card = platform_get_drvdata(dev); 268 268 ··· 270 270 snd_card_free(card); 271 271 pxa2xx_ac97_hw_remove(dev); 272 272 } 273 - 274 - return 0; 275 273 } 276 274 277 275 static struct platform_driver pxa2xx_ac97_driver = { 278 276 .probe = pxa2xx_ac97_probe, 279 - .remove = pxa2xx_ac97_remove, 277 + .remove_new = pxa2xx_ac97_remove, 280 278 .driver = { 281 279 .name = "pxa2xx-ac97", 282 280 #ifdef CONFIG_PM_SLEEP