Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

arm64: xor-neon: mark xor_arm64_neon_*() static

The only references to these functions are in the same file, and
there is no prototype, which causes a harmless warning:

arch/arm64/lib/xor-neon.c:13:6: error: no previous prototype for 'xor_arm64_neon_2' [-Werror=missing-prototypes]
arch/arm64/lib/xor-neon.c:40:6: error: no previous prototype for 'xor_arm64_neon_3' [-Werror=missing-prototypes]
arch/arm64/lib/xor-neon.c:76:6: error: no previous prototype for 'xor_arm64_neon_4' [-Werror=missing-prototypes]
arch/arm64/lib/xor-neon.c:121:6: error: no previous prototype for 'xor_arm64_neon_5' [-Werror=missing-prototypes]

Fixes: cc9f8349cb33 ("arm64: crypto: add NEON accelerated XOR implementation")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Kees Cook <keescook@chromium.org>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
Link: https://lore.kernel.org/r/20230516160642.523862-2-arnd@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>

authored by

Arnd Bergmann and committed by
Catalin Marinas
320a93d4 44c026a7

+4 -4
+4 -4
arch/arm64/lib/xor-neon.c
··· 10 10 #include <linux/module.h> 11 11 #include <asm/neon-intrinsics.h> 12 12 13 - void xor_arm64_neon_2(unsigned long bytes, unsigned long * __restrict p1, 13 + static void xor_arm64_neon_2(unsigned long bytes, unsigned long * __restrict p1, 14 14 const unsigned long * __restrict p2) 15 15 { 16 16 uint64_t *dp1 = (uint64_t *)p1; ··· 37 37 } while (--lines > 0); 38 38 } 39 39 40 - void xor_arm64_neon_3(unsigned long bytes, unsigned long * __restrict p1, 40 + static void xor_arm64_neon_3(unsigned long bytes, unsigned long * __restrict p1, 41 41 const unsigned long * __restrict p2, 42 42 const unsigned long * __restrict p3) 43 43 { ··· 73 73 } while (--lines > 0); 74 74 } 75 75 76 - void xor_arm64_neon_4(unsigned long bytes, unsigned long * __restrict p1, 76 + static void xor_arm64_neon_4(unsigned long bytes, unsigned long * __restrict p1, 77 77 const unsigned long * __restrict p2, 78 78 const unsigned long * __restrict p3, 79 79 const unsigned long * __restrict p4) ··· 118 118 } while (--lines > 0); 119 119 } 120 120 121 - void xor_arm64_neon_5(unsigned long bytes, unsigned long * __restrict p1, 121 + static void xor_arm64_neon_5(unsigned long bytes, unsigned long * __restrict p1, 122 122 const unsigned long * __restrict p2, 123 123 const unsigned long * __restrict p3, 124 124 const unsigned long * __restrict p4,