Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ptp: ptp_clockmatrix: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Link: https://lore.kernel.org/r/0f0f5680c1a2a3ef19975935a2c6828a98bc4d25.1712734365.git.u.kleine-koenig@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Uwe Kleine-König and committed by
Jakub Kicinski
32080ec2 5e317a2f

+2 -4
+2 -4
drivers/ptp/ptp_clockmatrix.c
··· 2457 2457 return 0; 2458 2458 } 2459 2459 2460 - static int idtcm_remove(struct platform_device *pdev) 2460 + static void idtcm_remove(struct platform_device *pdev) 2461 2461 { 2462 2462 struct idtcm *idtcm = platform_get_drvdata(pdev); 2463 2463 2464 2464 idtcm->extts_mask = 0; 2465 2465 ptp_clock_unregister_all(idtcm); 2466 2466 cancel_delayed_work_sync(&idtcm->extts_work); 2467 - 2468 - return 0; 2469 2467 } 2470 2468 2471 2469 static struct platform_driver idtcm_driver = { ··· 2471 2473 .name = "8a3400x-phc", 2472 2474 }, 2473 2475 .probe = idtcm_probe, 2474 - .remove = idtcm_remove, 2476 + .remove_new = idtcm_remove, 2475 2477 }; 2476 2478 2477 2479 module_platform_driver(idtcm_driver);