Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: ipa: fix two minor ipa_cmd problems

In "ipa_cmd.h", ipa_cmd_data_valid() is declared, but that function
does not exist. So delete that declaration.

Also, for some reason ipa_cmd_init() never gets called. It isn't
really critical--it just validates that some memory offsets and a
size can be represented in some register fields, and they won't fail
with current data. Regardless, call the function in ipa_probe().

Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>

authored by

Alex Elder and committed by
Paolo Abeni
319b6d4e f2e4e9ea

+4 -8
-8
drivers/net/ipa/ipa_cmd.h
··· 54 54 bool route); 55 55 56 56 /** 57 - * ipa_cmd_data_valid() - Validate command-realted configuration is valid 58 - * @ipa: - IPA pointer 59 - * 60 - * Return: true if assumptions required for command are valid 61 - */ 62 - bool ipa_cmd_data_valid(struct ipa *ipa); 63 - 64 - /** 65 57 * ipa_cmd_pool_init() - initialize command channel pools 66 58 * @channel: AP->IPA command TX GSI channel pointer 67 59 * @tre_count: Number of pool elements to allocate
+4
drivers/net/ipa/ipa_main.c
··· 865 865 if (ret) 866 866 goto err_reg_exit; 867 867 868 + ret = ipa_cmd_init(ipa); 869 + if (ret) 870 + goto err_mem_exit; 871 + 868 872 ret = gsi_init(&ipa->gsi, pdev, ipa->version, data->endpoint_count, 869 873 data->endpoint_data); 870 874 if (ret)