Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ASoC: ux500: ux500_msp_dai: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Takashi Iwai <tiwai@suse.de>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Link: https://lore.kernel.org/r/20230315150745.67084-169-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Uwe Kleine-König and committed by
Mark Brown
316a6bbf d2b6d5b8

+2 -4
+2 -4
sound/soc/ux500/ux500_msp_dai.c
··· 791 791 return ret; 792 792 } 793 793 794 - static int ux500_msp_drv_remove(struct platform_device *pdev) 794 + static void ux500_msp_drv_remove(struct platform_device *pdev) 795 795 { 796 796 struct ux500_msp_i2s_drvdata *drvdata = dev_get_drvdata(&pdev->dev); 797 797 ··· 802 802 prcmu_qos_remove_requirement(PRCMU_QOS_APE_OPP, "ux500_msp_i2s"); 803 803 804 804 ux500_msp_i2s_cleanup_msp(pdev, drvdata->msp); 805 - 806 - return 0; 807 805 } 808 806 809 807 static const struct of_device_id ux500_msp_i2s_match[] = { ··· 816 818 .of_match_table = ux500_msp_i2s_match, 817 819 }, 818 820 .probe = ux500_msp_drv_probe, 819 - .remove = ux500_msp_drv_remove, 821 + .remove_new = ux500_msp_drv_remove, 820 822 }; 821 823 module_platform_driver(msp_i2s_driver); 822 824