Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

RDMA/core: Remove unused ib_ud_header_unpack

ib_ud_header_unpack() is unused, and I can't see any sign of it
ever having been used in git. The only reference I can find
is from December 2004 BKrev: 41d30034XNbBUl0XnyC6ig9V61Nf-A when
it looks like it was added.

Remove it.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
Link: https://patch.msgid.link/20241221014021.343979-2-linux@treblig.org
Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>

authored by

Dr. David Alan Gilbert and committed by
Leon Romanovsky
30dd62fa 695df3e8

-86
-83
drivers/infiniband/core/ud_header.c
··· 462 462 return len; 463 463 } 464 464 EXPORT_SYMBOL(ib_ud_header_pack); 465 - 466 - /** 467 - * ib_ud_header_unpack - Unpack UD header struct from wire format 468 - * @header:UD header struct 469 - * @buf:Buffer to pack into 470 - * 471 - * ib_ud_header_pack() unpacks the UD header structure @header from wire 472 - * format in the buffer @buf. 473 - */ 474 - int ib_ud_header_unpack(void *buf, 475 - struct ib_ud_header *header) 476 - { 477 - ib_unpack(lrh_table, ARRAY_SIZE(lrh_table), 478 - buf, &header->lrh); 479 - buf += IB_LRH_BYTES; 480 - 481 - if (header->lrh.link_version != 0) { 482 - pr_warn("Invalid LRH.link_version %u\n", 483 - header->lrh.link_version); 484 - return -EINVAL; 485 - } 486 - 487 - switch (header->lrh.link_next_header) { 488 - case IB_LNH_IBA_LOCAL: 489 - header->grh_present = 0; 490 - break; 491 - 492 - case IB_LNH_IBA_GLOBAL: 493 - header->grh_present = 1; 494 - ib_unpack(grh_table, ARRAY_SIZE(grh_table), 495 - buf, &header->grh); 496 - buf += IB_GRH_BYTES; 497 - 498 - if (header->grh.ip_version != 6) { 499 - pr_warn("Invalid GRH.ip_version %u\n", 500 - header->grh.ip_version); 501 - return -EINVAL; 502 - } 503 - if (header->grh.next_header != 0x1b) { 504 - pr_warn("Invalid GRH.next_header 0x%02x\n", 505 - header->grh.next_header); 506 - return -EINVAL; 507 - } 508 - break; 509 - 510 - default: 511 - pr_warn("Invalid LRH.link_next_header %u\n", 512 - header->lrh.link_next_header); 513 - return -EINVAL; 514 - } 515 - 516 - ib_unpack(bth_table, ARRAY_SIZE(bth_table), 517 - buf, &header->bth); 518 - buf += IB_BTH_BYTES; 519 - 520 - switch (header->bth.opcode) { 521 - case IB_OPCODE_UD_SEND_ONLY: 522 - header->immediate_present = 0; 523 - break; 524 - case IB_OPCODE_UD_SEND_ONLY_WITH_IMMEDIATE: 525 - header->immediate_present = 1; 526 - break; 527 - default: 528 - pr_warn("Invalid BTH.opcode 0x%02x\n", header->bth.opcode); 529 - return -EINVAL; 530 - } 531 - 532 - if (header->bth.transport_header_version != 0) { 533 - pr_warn("Invalid BTH.transport_header_version %u\n", 534 - header->bth.transport_header_version); 535 - return -EINVAL; 536 - } 537 - 538 - ib_unpack(deth_table, ARRAY_SIZE(deth_table), 539 - buf, &header->deth); 540 - buf += IB_DETH_BYTES; 541 - 542 - if (header->immediate_present) 543 - memcpy(&header->immediate_data, buf, sizeof header->immediate_data); 544 - 545 - return 0; 546 - } 547 - EXPORT_SYMBOL(ib_ud_header_unpack);
-3
include/rdma/ib_pack.h
··· 283 283 int ib_ud_header_pack(struct ib_ud_header *header, 284 284 void *buf); 285 285 286 - int ib_ud_header_unpack(void *buf, 287 - struct ib_ud_header *header); 288 - 289 286 #endif /* IB_PACK_H */