ima: process_measurement() needlessly takes inode_lock() on MAY_READ

On IMA policy update, if a measure rule exists in the policy,
IMA_MEASURE is set for ima_policy_flags which makes the violation_check
variable always true. Coupled with a no-action on MAY_READ for a
FILE_CHECK call, we're always taking the inode_lock().

This becomes a performance problem for extremely heavy read-only workloads.
Therefore, prevent this only in the case there's no action to be taken.

Signed-off-by: Frederick Lawler <fred@cloudflare.com>
Acked-by: Roberto Sassu <roberto.sassu@huawei.com>
Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>

authored by Frederick Lawler and committed by Roberto Sassu 30d68cb0 9c32cda4

+3 -1
+3 -1
security/integrity/ima/ima_main.c
··· 245 &allowed_algos); 246 violation_check = ((func == FILE_CHECK || func == MMAP_CHECK || 247 func == MMAP_CHECK_REQPROT) && 248 - (ima_policy_flag & IMA_MEASURE)); 249 if (!action && !violation_check) 250 return 0; 251
··· 245 &allowed_algos); 246 violation_check = ((func == FILE_CHECK || func == MMAP_CHECK || 247 func == MMAP_CHECK_REQPROT) && 248 + (ima_policy_flag & IMA_MEASURE) && 249 + ((action & IMA_MEASURE) || 250 + (file->f_mode & FMODE_WRITE))); 251 if (!action && !violation_check) 252 return 0; 253