Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Drivers: hv: vmbus: Don't free ring buffers that couldn't be re-encrypted

In CoCo VMs it is possible for the untrusted host to cause
set_memory_encrypted() or set_memory_decrypted() to fail such that an
error is returned and the resulting memory is shared. Callers need to
take care to handle these errors to avoid returning decrypted (shared)
memory to the page allocator, which could lead to functional or security
issues.

The VMBus ring buffer code could free decrypted/shared pages if
set_memory_decrypted() fails. Check the decrypted field in the struct
vmbus_gpadl for the ring buffers to decide whether to free the memory.

Signed-off-by: Michael Kelley <mhklinux@outlook.com>
Reviewed-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Link: https://lore.kernel.org/r/20240311161558.1310-6-mhklinux@outlook.com
Signed-off-by: Wei Liu <wei.liu@kernel.org>
Message-ID: <20240311161558.1310-6-mhklinux@outlook.com>

authored by

Michael Kelley and committed by
Wei Liu
30d18df6 3d788b2f

+3 -1
+3 -1
drivers/hv/channel.c
··· 153 153 hv_ringbuffer_cleanup(&channel->inbound); 154 154 155 155 if (channel->ringbuffer_page) { 156 - __free_pages(channel->ringbuffer_page, 156 + /* In a CoCo VM leak the memory if it didn't get re-encrypted */ 157 + if (!channel->ringbuffer_gpadlhandle.decrypted) 158 + __free_pages(channel->ringbuffer_page, 157 159 get_order(channel->ringbuffer_pagecount 158 160 << PAGE_SHIFT)); 159 161 channel->ringbuffer_page = NULL;