Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/mediatek: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20231102165640.3307820-30-u.kleine-koenig@pengutronix.de

authored by

Uwe Kleine-König and committed by
Thomas Zimmermann
30b749ad 8c67c9a4

+4 -6
+2 -3
drivers/gpu/drm/mediatek/mtk_disp_ovl_adaptor.c
··· 531 531 return ret; 532 532 } 533 533 534 - static int mtk_disp_ovl_adaptor_remove(struct platform_device *pdev) 534 + static void mtk_disp_ovl_adaptor_remove(struct platform_device *pdev) 535 535 { 536 536 component_master_del(&pdev->dev, &mtk_disp_ovl_adaptor_master_ops); 537 537 pm_runtime_disable(&pdev->dev); 538 - return 0; 539 538 } 540 539 541 540 struct platform_driver mtk_disp_ovl_adaptor_driver = { 542 541 .probe = mtk_disp_ovl_adaptor_probe, 543 - .remove = mtk_disp_ovl_adaptor_remove, 542 + .remove_new = mtk_disp_ovl_adaptor_remove, 544 543 .driver = { 545 544 .name = "mediatek-disp-ovl-adaptor", 546 545 .owner = THIS_MODULE,
+2 -3
drivers/gpu/drm/mediatek/mtk_ethdr.c
··· 346 346 return ret; 347 347 } 348 348 349 - static int mtk_ethdr_remove(struct platform_device *pdev) 349 + static void mtk_ethdr_remove(struct platform_device *pdev) 350 350 { 351 351 component_del(&pdev->dev, &mtk_ethdr_component_ops); 352 - return 0; 353 352 } 354 353 355 354 static const struct of_device_id mtk_ethdr_driver_dt_match[] = { ··· 360 361 361 362 struct platform_driver mtk_ethdr_driver = { 362 363 .probe = mtk_ethdr_probe, 363 - .remove = mtk_ethdr_remove, 364 + .remove_new = mtk_ethdr_remove, 364 365 .driver = { 365 366 .name = "mediatek-disp-ethdr", 366 367 .owner = THIS_MODULE,