Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

dlm: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230510221237.3509484-1-azeemshaikh38@gmail.com

authored by

Azeem Shaikh and committed by
Kees Cook
30ad0627 df8fc4e9

+2 -2
+2 -2
fs/dlm/config.c
··· 116 116 { 117 117 struct dlm_cluster *cl = config_item_to_cluster(item); 118 118 119 - strlcpy(dlm_config.ci_cluster_name, buf, 119 + strscpy(dlm_config.ci_cluster_name, buf, 120 120 sizeof(dlm_config.ci_cluster_name)); 121 - strlcpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name)); 121 + strscpy(cl->cl_cluster_name, buf, sizeof(cl->cl_cluster_name)); 122 122 return len; 123 123 } 124 124