Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: pisosr: Simplify with dev_err_probe()

Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

authored by

Krzysztof Kozlowski and committed by
Bartosz Golaszewski
308a028d ca6a77eb

+3 -6
+3 -6
drivers/gpio/gpio-pisosr.c
··· 148 148 return -ENOMEM; 149 149 150 150 gpio->load_gpio = devm_gpiod_get_optional(dev, "load", GPIOD_OUT_LOW); 151 - if (IS_ERR(gpio->load_gpio)) { 152 - ret = PTR_ERR(gpio->load_gpio); 153 - if (ret != -EPROBE_DEFER) 154 - dev_err(dev, "Unable to allocate load GPIO\n"); 155 - return ret; 156 - } 151 + if (IS_ERR(gpio->load_gpio)) 152 + return dev_err_probe(dev, PTR_ERR(gpio->load_gpio), 153 + "Unable to allocate load GPIO\n"); 157 154 158 155 mutex_init(&gpio->lock); 159 156