Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

genhd: Rename get_disk() to get_disk_and_module()

Rename get_disk() to get_disk_and_module() to make sure what the
function does. It's not a great name but at least it is now clear that
put_disk() is not it's counterpart.

Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

authored by

Jan Kara and committed by
Jens Axboe
3079c22e d52987b5

+13 -15
+4 -6
block/genhd.c
··· 547 547 { 548 548 struct gendisk *p = data; 549 549 550 - if (!get_disk(p)) 550 + if (!get_disk_and_module(p)) 551 551 return -1; 552 552 return 0; 553 553 } ··· 809 809 810 810 spin_lock_bh(&ext_devt_lock); 811 811 part = idr_find(&ext_devt_idr, blk_mangle_minor(MINOR(devt))); 812 - if (part && get_disk(part_to_disk(part))) { 812 + if (part && get_disk_and_module(part_to_disk(part))) { 813 813 *partno = part->partno; 814 814 disk = part_to_disk(part); 815 815 } ··· 1456 1456 } 1457 1457 EXPORT_SYMBOL(__alloc_disk_node); 1458 1458 1459 - struct kobject *get_disk(struct gendisk *disk) 1459 + struct kobject *get_disk_and_module(struct gendisk *disk) 1460 1460 { 1461 1461 struct module *owner; 1462 1462 struct kobject *kobj; ··· 1474 1474 return kobj; 1475 1475 1476 1476 } 1477 - 1478 - EXPORT_SYMBOL(get_disk); 1477 + EXPORT_SYMBOL(get_disk_and_module); 1479 1478 1480 1479 void put_disk(struct gendisk *disk) 1481 1480 { 1482 1481 if (disk) 1483 1482 kobject_put(&disk_to_dev(disk)->kobj); 1484 1483 } 1485 - 1486 1484 EXPORT_SYMBOL(put_disk); 1487 1485 1488 1486 static void set_disk_ro_uevent(struct gendisk *gd, int ro)
+1 -1
drivers/block/amiflop.c
··· 1758 1758 if (unit[drive].type->code == FD_NODRIVE) 1759 1759 return NULL; 1760 1760 *part = 0; 1761 - return get_disk(unit[drive].gendisk); 1761 + return get_disk_and_module(unit[drive].gendisk); 1762 1762 } 1763 1763 1764 1764 static int __init amiga_floppy_probe(struct platform_device *pdev)
+1 -1
drivers/block/ataflop.c
··· 1917 1917 if (drive >= FD_MAX_UNITS || type > NUM_DISK_MINORS) 1918 1918 return NULL; 1919 1919 *part = 0; 1920 - return get_disk(unit[drive].disk); 1920 + return get_disk_and_module(unit[drive].disk); 1921 1921 } 1922 1922 1923 1923 static int __init atari_floppy_init (void)
+1 -1
drivers/block/brd.c
··· 456 456 457 457 mutex_lock(&brd_devices_mutex); 458 458 brd = brd_init_one(MINOR(dev) / max_part, &new); 459 - kobj = brd ? get_disk(brd->brd_disk) : NULL; 459 + kobj = brd ? get_disk_and_module(brd->brd_disk) : NULL; 460 460 mutex_unlock(&brd_devices_mutex); 461 461 462 462 if (new)
+1 -1
drivers/block/floppy.c
··· 4505 4505 if (((*part >> 2) & 0x1f) >= ARRAY_SIZE(floppy_type)) 4506 4506 return NULL; 4507 4507 *part = 0; 4508 - return get_disk(disks[drive]); 4508 + return get_disk_and_module(disks[drive]); 4509 4509 } 4510 4510 4511 4511 static int __init do_floppy_init(void)
+1 -1
drivers/block/loop.c
··· 1922 1922 if (err < 0) 1923 1923 kobj = NULL; 1924 1924 else 1925 - kobj = get_disk(lo->lo_disk); 1925 + kobj = get_disk_and_module(lo->lo_disk); 1926 1926 mutex_unlock(&loop_index_mutex); 1927 1927 1928 1928 *part = 0;
+1 -1
drivers/block/swim.c
··· 799 799 return NULL; 800 800 801 801 *part = 0; 802 - return get_disk(swd->unit[drive].disk); 802 + return get_disk_and_module(swd->unit[drive].disk); 803 803 } 804 804 805 805 static int swim_add_floppy(struct swim_priv *swd, enum drive_location location)
+1 -1
drivers/block/z2ram.c
··· 332 332 static struct kobject *z2_find(dev_t dev, int *part, void *data) 333 333 { 334 334 *part = 0; 335 - return get_disk(z2ram_gendisk); 335 + return get_disk_and_module(z2ram_gendisk); 336 336 } 337 337 338 338 static struct request_queue *z2_queue;
+1 -1
drivers/ide/ide-probe.c
··· 928 928 { 929 929 struct gendisk *p = data; 930 930 931 - if (!get_disk(p)) 931 + if (!get_disk_and_module(p)) 932 932 return -1; 933 933 return 0; 934 934 }
+1 -1
include/linux/genhd.h
··· 600 600 extern void printk_all_partitions(void); 601 601 602 602 extern struct gendisk *__alloc_disk_node(int minors, int node_id); 603 - extern struct kobject *get_disk(struct gendisk *disk); 603 + extern struct kobject *get_disk_and_module(struct gendisk *disk); 604 604 extern void put_disk(struct gendisk *disk); 605 605 extern void blk_register_region(dev_t devt, unsigned long range, 606 606 struct module *module,