Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

ARM: OMAP2+: add missing of_node_put after of_device_is_available

Add an of_node_put when a tested device node is not available.

The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):

// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@

e = f(...);
... when != of_node_put(e)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
// </smpl>

Fixes: e0c827aca0730 ("drm/omap: Populate DSS children in omapdss driver")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Tony Lindgren <tony@atomide.com>

authored by

Julia Lawall and committed by
Tony Lindgren
30645307 3e2cf62e

+3 -1
+3 -1
arch/arm/mach-omap2/display.c
··· 250 250 if (!node) 251 251 return 0; 252 252 253 - if (!of_device_is_available(node)) 253 + if (!of_device_is_available(node)) { 254 + of_node_put(node); 254 255 return 0; 256 + } 255 257 256 258 pdev = of_find_device_by_node(node); 257 259