af_unix: introduce and use scm_replace_pid() helper

Existing logic in __scm_send() related to filling an struct scm_cookie
with a proper struct pid reference is already pretty tricky. Let's
simplify it a bit by introducing a new helper. This helper will be
extended in one of the next patches.

Cc: [e-mail]
Cc: [e-mail]
Cc: David S. Miller <[e-mail]>
Cc: Eric Dumazet <[e-mail]>
Cc: Jakub Kicinski <[e-mail]>
Cc: Paolo Abeni <[e-mail]>
Cc: Simon Horman <[e-mail]>
Cc: Willem de Bruijn <[e-mail]>
Cc: Leon Romanovsky <[e-mail]>
Cc: Arnd Bergmann <[e-mail]>
Cc: Christian Brauner <[e-mail]>
Cc: Kuniyuki Iwashima <[e-mail]>
Cc: Lennart Poettering <[e-mail]>
Cc: Luca Boccassi <[e-mail]>
Cc: David Rheinsberg <[e-mail]>
Signed-off-by: Alexander Mikhalitsyn <[e-mail]>
Link: https://lore.kernel.org/[e-mail]
Reviewed-by: Kuniyuki Iwashima <[e-mail]>
Signed-off-by: Christian Brauner <[e-mail]>

net/core/scm.c

···
 }
 EXPORT_SYMBOL(__scm_destroy);
 
+static inline int scm_replace_pid(struct scm_cookie *scm, struct pid *pid)
+{
+	/* drop all previous references */
+	scm_destroy_cred(scm);
+
+	scm->pid = pid;
+	scm->creds.pid = pid_vnr(pid);
+	return 0;
+}
+
 int __scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *p)
 {
 	const struct proto_ops *ops = READ_ONCE(sock->ops);
···
 			if (err)
 				goto error;
 
-			p->creds.pid = creds.pid;
 			if (!p->pid || pid_vnr(p->pid) != creds.pid) {
 				struct pid *pid;
 				err = -ESRCH;
 				pid = find_get_pid(creds.pid);
 				if (!pid)
 					goto error;
-				put_pid(p->pid);
-				p->pid = pid;
+
+				/* pass a struct pid reference from
+				 * find_get_pid() to scm_replace_pid().
+				 */
+				err = scm_replace_pid(p, pid);
+				if (err) {
+					put_pid(pid);
+					goto error;
+				}
 			}
 
 			err = -EINVAL;