Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

gpio: raspberrypi-exp: remove redundant of_match_ptr()

The driver depends on CONFIG_OF, so it is not necessary to use
of_match_ptr() here, and __maybe_unused can also be removed.

Even for drivers that do not depend on CONFIG_OF, it's almost always
better to leave out the of_match_ptr(), since the only thing it can
possibly do is to save a few bytes of .text if a driver can be used both
with and without it.

Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

authored by

Zhu Wang and committed by
Bartosz Golaszewski
30531e14 58787538

+2 -2
+2 -2
drivers/gpio/gpio-raspberrypi-exp.c
··· 234 234 return devm_gpiochip_add_data(dev, &rpi_gpio->gc, rpi_gpio); 235 235 } 236 236 237 - static const struct of_device_id rpi_exp_gpio_ids[] __maybe_unused = { 237 + static const struct of_device_id rpi_exp_gpio_ids[] = { 238 238 { .compatible = "raspberrypi,firmware-gpio" }, 239 239 { } 240 240 }; ··· 243 243 static struct platform_driver rpi_exp_gpio_driver = { 244 244 .driver = { 245 245 .name = MODULE_NAME, 246 - .of_match_table = of_match_ptr(rpi_exp_gpio_ids), 246 + .of_match_table = rpi_exp_gpio_ids, 247 247 }, 248 248 .probe = rpi_exp_gpio_probe, 249 249 };