net: irda: avoid null pointer dereference

Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

kernel os linux

Only dereference variable self after checking it is not NULL.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

xypron.glpk@gmx.de and committed by

David S. Miller 10 years ago 30119059 d1134128

+2 -1

1 changed file

expand all

drivers

net

irda

nsc-ircc.c

+2 -1

drivers/net/irda/nsc-ircc.c

··· 1253 1253 */ 1254 1254 static __u8 nsc_ircc_change_speed(struct nsc_ircc_cb *self, __u32 speed) 1255 1255 { 1256 - struct net_device *dev = self->netdev; 1256 + struct net_device *dev; 1257 1257 __u8 mcr = MCR_SIR; 1258 1258 int iobase; 1259 1259 __u8 bank; ··· 1263 1263 1264 1264 IRDA_ASSERT(self != NULL, return 0;); 1265 1265 1266 + dev = self->netdev; 1266 1267 iobase = self->io.fir_base; 1267 1268 1268 1269 /* Update accounting for new speed */