Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

thunderbolt: Fix double free of drom buffer

If tb_drom_read() fails, sw->drom is freed but not set to NULL. sw->drom
is then freed again in the error path of tb_switch_alloc().

The bug can be triggered by unplugging a thunderbolt device shortly after
it is detected by the thunderbolt driver.

Clear sw->drom if tb_drom_read() fails.

[bhelgaas: add Fixes:, stable versions of interest]
Fixes: 343fcb8c70d7 ("thunderbolt: Fix nontrivial endpoint devices.")
Signed-off-by: Andreas Noever <andreas.noever@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
CC: stable@vger.kernel.org # v3.17+
CC: Lukas Wunner <lukas@wunner.de>

authored by

Andreas Noever and committed by
Bjorn Helgaas
2ffa9a5d 19bf4d4f

+1
+1
drivers/thunderbolt/eeprom.c
··· 449 449 return tb_drom_parse_entries(sw); 450 450 err: 451 451 kfree(sw->drom); 452 + sw->drom = NULL; 452 453 return -EIO; 453 454 454 455 }