Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

perf hwmon_pmu: Fix uninitialized variable warning

The line_len is only set on success. Check the return value instead.

util/hwmon_pmu.c: In function ‘perf_pmus__read_hwmon_pmus’:
util/hwmon_pmu.c:742:20: warning: ‘line_len’ may be used uninitialized [-Wmaybe-uninitialized]
742 | if (line_len > 0 && line[line_len - 1] == '\n')
| ^
util/hwmon_pmu.c:719:24: note: ‘line_len’ was declared here
719 | size_t line_len;

Fixes: 53cc0b351ec9 ("perf hwmon_pmu: Add a tool PMU exposing events from hwmon in sysfs")
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
Signed-off-by: Namhyung Kim <namhyung@kernel.org>

authored by

Michal Suchanek and committed by
Namhyung Kim
2fee899c ab29ff9f

+1 -2
+1 -2
tools/perf/util/hwmon_pmu.c
··· 742 742 continue; 743 743 } 744 744 io__init(&io, name_fd, buf2, sizeof(buf2)); 745 - io__getline(&io, &line, &line_len); 746 - if (line_len > 0 && line[line_len - 1] == '\n') 745 + if (io__getline(&io, &line, &line_len) > 0 && line[line_len - 1] == '\n') 747 746 line[line_len - 1] = '\0'; 748 747 hwmon_pmu__new(pmus, buf, class_hwmon_ent->d_name, line); 749 748 close(name_fd);