Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

crypto: intel/ixp4xx-crypto - Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Corentin Labbe <clabbe@baylibre.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

authored by

Uwe Kleine-König and committed by
Herbert Xu
2fd7c206 4f7f841f

+2 -4
+2 -4
drivers/crypto/intel/ixp4xx/ixp4xx_crypto.c
··· 1563 1563 return 0; 1564 1564 } 1565 1565 1566 - static int ixp_crypto_remove(struct platform_device *pdev) 1566 + static void ixp_crypto_remove(struct platform_device *pdev) 1567 1567 { 1568 1568 int num = ARRAY_SIZE(ixp4xx_algos); 1569 1569 int i; ··· 1578 1578 crypto_unregister_skcipher(&ixp4xx_algos[i].crypto); 1579 1579 } 1580 1580 release_ixp_crypto(&pdev->dev); 1581 - 1582 - return 0; 1583 1581 } 1584 1582 static const struct of_device_id ixp4xx_crypto_of_match[] = { 1585 1583 { ··· 1588 1590 1589 1591 static struct platform_driver ixp_crypto_driver = { 1590 1592 .probe = ixp_crypto_probe, 1591 - .remove = ixp_crypto_remove, 1593 + .remove_new = ixp_crypto_remove, 1592 1594 .driver = { 1593 1595 .name = "ixp4xx_crypto", 1594 1596 .of_match_table = ixp4xx_crypto_of_match,