Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge branch 'net-ptp-introduce-common-defines-for-ptp-message-types'

Christian Eggers says:

====================
net: ptp: introduce common defines for PTP message types

This series introduces commen defines for PTP event messages. Driver
internal defines are removed and some uses of magic numbers are replaced
by the new defines.
====================

Link: https://lore.kernel.org/r/20201120084106.10046-1-ceggers@arri.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

+15 -15
+2 -2
drivers/net/ethernet/freescale/dpaa2/dpaa2-eth.c
··· 686 686 if (skb->cb[0] == TX_TSTAMP_ONESTEP_SYNC) { 687 687 if (dpaa2_eth_ptp_parse(skb, &msgtype, &twostep, &udp, 688 688 &offset1, &offset2) || 689 - msgtype != 0 || twostep) { 689 + msgtype != PTP_MSGTYPE_SYNC || twostep) { 690 690 WARN_ONCE(1, "Bad packet for one-step timestamping\n"); 691 691 return; 692 692 } ··· 1212 1212 if (skb->cb[0] == TX_TSTAMP_ONESTEP_SYNC) { 1213 1213 if (!dpaa2_eth_ptp_parse(skb, &msgtype, &twostep, &udp, 1214 1214 &offset1, &offset2)) 1215 - if (msgtype == 0 && twostep == 0) { 1215 + if (msgtype == PTP_MSGTYPE_SYNC && twostep == 0) { 1216 1216 skb_queue_tail(&priv->tx_skbs, skb); 1217 1217 queue_work(priv->dpaa2_ptp_wq, 1218 1218 &priv->tx_onestep_tstamp);
+7 -12
drivers/ptp/ptp_ines.c
··· 108 108 #define MESSAGE_TYPE_P_DELAY_RESP 3 109 109 #define MESSAGE_TYPE_DELAY_REQ 4 110 110 111 - #define SYNC 0x0 112 - #define DELAY_REQ 0x1 113 - #define PDELAY_REQ 0x2 114 - #define PDELAY_RESP 0x3 115 - 116 111 static LIST_HEAD(ines_clocks); 117 112 static DEFINE_MUTEX(ines_clocks_lock); 118 113 ··· 678 683 679 684 msgtype = ptp_get_msgtype(hdr, type); 680 685 681 - switch ((msgtype & 0xf)) { 682 - case SYNC: 683 - case PDELAY_RESP: 686 + switch (msgtype) { 687 + case PTP_MSGTYPE_SYNC: 688 + case PTP_MSGTYPE_PDELAY_RESP: 684 689 return true; 685 690 default: 686 691 return false; ··· 691 696 { 692 697 switch (tag) { 693 698 case MESSAGE_TYPE_SYNC: 694 - return SYNC; 699 + return PTP_MSGTYPE_SYNC; 695 700 case MESSAGE_TYPE_P_DELAY_REQ: 696 - return PDELAY_REQ; 701 + return PTP_MSGTYPE_PDELAY_REQ; 697 702 case MESSAGE_TYPE_P_DELAY_RESP: 698 - return PDELAY_RESP; 703 + return PTP_MSGTYPE_PDELAY_RESP; 699 704 case MESSAGE_TYPE_DELAY_REQ: 700 - return DELAY_REQ; 705 + return PTP_MSGTYPE_DELAY_REQ; 701 706 } 702 707 return 0xf; 703 708 }
+6 -1
include/linux/ptp_classify.h
··· 31 31 #define PTP_CLASS_V2_VLAN (PTP_CLASS_V2 | PTP_CLASS_VLAN) 32 32 #define PTP_CLASS_L4 (PTP_CLASS_IPV4 | PTP_CLASS_IPV6) 33 33 34 + #define PTP_MSGTYPE_SYNC 0x0 35 + #define PTP_MSGTYPE_DELAY_REQ 0x1 36 + #define PTP_MSGTYPE_PDELAY_REQ 0x2 37 + #define PTP_MSGTYPE_PDELAY_RESP 0x3 38 + 34 39 #define PTP_EV_PORT 319 35 40 #define PTP_GEN_BIT 0x08 /* indicates general message, if set in message type */ 36 41 ··· 145 140 /* The return is meaningless. The stub function would not be 146 141 * executed since no available header from ptp_parse_header. 147 142 */ 148 - return 0; 143 + return PTP_MSGTYPE_SYNC; 149 144 } 150 145 #endif 151 146 #endif /* _PTP_CLASSIFY_H_ */