Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Orangefs: fix ifnullfree.cocci warnings

fs/orangefs/orangefs-debugfs.c:130:2-26: WARNING: NULL check before freeing functions like kfree, debugfs_remove, debugfs_remove_recursive or usb_free_urb is not needed. Maybe consider reorganizing relevant code to avoid passing NULL values.

NULL check before some freeing functions is not needed.

Based on checkpatch warning
"kfree(NULL) is safe this check is probably not required"
and kfreeaddr.cocci by Julia Lawall.

Generated by: scripts/coccinelle/free/ifnullfree.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Mike Marshall <hubcap@omnibond.com>

authored by

kbuild test robot and committed by
Mike Marshall
2fa37fd7 a9bb3ba8

+1 -2
+1 -2
fs/orangefs/orangefs-debugfs.c
··· 126 126 127 127 void orangefs_debugfs_cleanup(void) 128 128 { 129 - if (debug_dir) 130 - debugfs_remove_recursive(debug_dir); 129 + debugfs_remove_recursive(debug_dir); 131 130 } 132 131 133 132 /* open ORANGEFS_KMOD_DEBUG_HELP_FILE */