Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/panel: novatek,nt39016: Reorder calls in probe

The drm_panel_of_backlight() function must be called after
drm_panel_init(), according to the function's documentation; otherwise
the backlight won't be properly initialized.

Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20200820121256.32037-2-paul@crapouillou.net

+3 -3
+3 -3
drivers/gpu/drm/panel/panel-novatek-nt39016.c
··· 285 285 return PTR_ERR(panel->map); 286 286 } 287 287 288 + drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, 289 + DRM_MODE_CONNECTOR_DPI); 290 + 288 291 err = drm_panel_of_backlight(&panel->drm_panel); 289 292 if (err) { 290 293 if (err != -EPROBE_DEFER) 291 294 dev_err(dev, "Failed to get backlight handle\n"); 292 295 return err; 293 296 } 294 - 295 - drm_panel_init(&panel->drm_panel, dev, &nt39016_funcs, 296 - DRM_MODE_CONNECTOR_DPI); 297 297 298 298 drm_panel_add(&panel->drm_panel); 299 299