Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

fsi: sbefifo: Remove limits on user-specified read timeout

There's no reason to limit the user here. The way the driver is
designed, extremely large transfers require extremely long timeouts.

Signed-off-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20230612195657.245125-7-eajames@linux.ibm.com
Signed-off-by: Joel Stanley <joel@jms.id.au>

authored by

Eddie James and committed by
Joel Stanley
2f42220f 19c064de

+2 -7
+2 -7
drivers/fsi/fsi-sbefifo.c
··· 971 971 972 972 if (timeout == 0) { 973 973 user->read_timeout_ms = SBEFIFO_TIMEOUT_START_RSP; 974 - dev_dbg(dev, "Timeout reset to %d\n", user->read_timeout_ms); 974 + dev_dbg(dev, "Timeout reset to %us\n", user->read_timeout_ms / 1000); 975 975 return 0; 976 976 } 977 977 978 - if (timeout < 10 || timeout > 120) 979 - return -EINVAL; 980 - 981 978 user->read_timeout_ms = timeout * 1000; /* user timeout is in sec */ 982 - 983 - dev_dbg(dev, "Timeout set to %d\n", user->read_timeout_ms); 984 - 979 + dev_dbg(dev, "Timeout set to %us\n", timeout); 985 980 return 0; 986 981 } 987 982