Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/v3d: Skip debugfs dumping GCA on platforms without GCA.

Fixes an oops reading this debugfs entry on BCM7278.

Signed-off-by: Eric Anholt <eric@anholt.net>
Link: https://patchwork.freedesktop.org/patch/msgid/20180928232126.4332-4-eric@anholt.net
Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+")
Cc: <stable@vger.kernel.org>
Reviewed-by: Boris Brezillon <boris.brezillon@bootlin.com>

+7 -4
+7 -4
drivers/gpu/drm/v3d/v3d_debugfs.c
··· 71 71 V3D_READ(v3d_hub_reg_defs[i].reg)); 72 72 } 73 73 74 - for (i = 0; i < ARRAY_SIZE(v3d_gca_reg_defs); i++) { 75 - seq_printf(m, "%s (0x%04x): 0x%08x\n", 76 - v3d_gca_reg_defs[i].name, v3d_gca_reg_defs[i].reg, 77 - V3D_GCA_READ(v3d_gca_reg_defs[i].reg)); 74 + if (v3d->ver < 41) { 75 + for (i = 0; i < ARRAY_SIZE(v3d_gca_reg_defs); i++) { 76 + seq_printf(m, "%s (0x%04x): 0x%08x\n", 77 + v3d_gca_reg_defs[i].name, 78 + v3d_gca_reg_defs[i].reg, 79 + V3D_GCA_READ(v3d_gca_reg_defs[i].reg)); 80 + } 78 81 } 79 82 80 83 for (core = 0; core < v3d->cores; core++) {