Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

nvme-pci: compile warnings in nvme_alloc_host_mem()

"i" should be signed or it could cause a forever loop on the cleanup
path. "size" can be used uninitialized.

Fixes: 87ad72a59a38 ("nvme-pci: implement host memory buffer support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

authored by

Dan Carpenter and committed by
Sagi Grimberg
2ee0e4ed 4cb7ca80

+3 -2
+3 -2
drivers/nvme/host/pci.c
··· 1582 1582 static int nvme_alloc_host_mem(struct nvme_dev *dev, u64 min, u64 preferred) 1583 1583 { 1584 1584 struct nvme_host_mem_buf_desc *descs; 1585 - u32 chunk_size, max_entries, i = 0; 1585 + u32 chunk_size, max_entries; 1586 + int i = 0; 1586 1587 void **bufs; 1587 - u64 size, tmp; 1588 + u64 size = 0, tmp; 1588 1589 1589 1590 /* start big and work our way down */ 1590 1591 chunk_size = min(preferred, (u64)PAGE_SIZE << MAX_ORDER);