Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

target: Remove unused target_core_fabric_ops.get_fabric_sense_len method

There are no callers of se_tfo->get_fabric_sense_len(), so we should
stop having every fabric driver implement it.

Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>

authored by

Roland Dreier and committed by
Nicholas Bellinger
2ed772b7 343d475d

-65
-8
Documentation/target/tcm_mod_builder.py
··· 402 402 buf += " .queue_data_in = " + fabric_mod_name + "_queue_data_in,\n" 403 403 buf += " .queue_status = " + fabric_mod_name + "_queue_status,\n" 404 404 buf += " .queue_tm_rsp = " + fabric_mod_name + "_queue_tm_rsp,\n" 405 - buf += " .get_fabric_sense_len = " + fabric_mod_name + "_get_fabric_sense_len,\n" 406 405 buf += " .set_fabric_sense_len = " + fabric_mod_name + "_set_fabric_sense_len,\n" 407 406 buf += " .is_state_remove = " + fabric_mod_name + "_is_state_remove,\n" 408 407 buf += " /*\n" ··· 904 905 buf += " return 0;\n" 905 906 buf += "}\n\n" 906 907 bufi += "int " + fabric_mod_name + "_queue_tm_rsp(struct se_cmd *);\n" 907 - 908 - if re.search('get_fabric_sense_len\)\(', fo): 909 - buf += "u16 " + fabric_mod_name + "_get_fabric_sense_len(void)\n" 910 - buf += "{\n" 911 - buf += " return 0;\n" 912 - buf += "}\n\n" 913 - bufi += "u16 " + fabric_mod_name + "_get_fabric_sense_len(void);\n" 914 908 915 909 if re.search('set_fabric_sense_len\)\(', fo): 916 910 buf += "u16 " + fabric_mod_name + "_set_fabric_sense_len(struct se_cmd *se_cmd, u32 sense_length)\n"
-6
drivers/infiniband/ulp/srpt/ib_srpt.c
··· 3569 3569 return 0; 3570 3570 } 3571 3571 3572 - static u16 srpt_get_fabric_sense_len(void) 3573 - { 3574 - return 0; 3575 - } 3576 - 3577 3572 /** 3578 3573 * srpt_parse_i_port_id() - Parse an initiator port ID. 3579 3574 * @name: ASCII representation of a 128-bit initiator port ID. ··· 3948 3953 .queue_data_in = srpt_queue_response, 3949 3954 .queue_status = srpt_queue_status, 3950 3955 .queue_tm_rsp = srpt_queue_response, 3951 - .get_fabric_sense_len = srpt_get_fabric_sense_len, 3952 3956 .set_fabric_sense_len = srpt_set_fabric_sense_len, 3953 3957 /* 3954 3958 * Setup function pointers for generic logic in
-7
drivers/scsi/qla2xxx/tcm_qla2xxx.c
··· 735 735 return 0; 736 736 } 737 737 738 - static u16 tcm_qla2xxx_get_fabric_sense_len(void) 739 - { 740 - return 0; 741 - } 742 - 743 738 static u16 tcm_qla2xxx_set_fabric_sense_len(struct se_cmd *se_cmd, 744 739 u32 sense_length) 745 740 { ··· 1686 1691 .queue_data_in = tcm_qla2xxx_queue_data_in, 1687 1692 .queue_status = tcm_qla2xxx_queue_status, 1688 1693 .queue_tm_rsp = tcm_qla2xxx_queue_tm_rsp, 1689 - .get_fabric_sense_len = tcm_qla2xxx_get_fabric_sense_len, 1690 1694 .set_fabric_sense_len = tcm_qla2xxx_set_fabric_sense_len, 1691 1695 /* 1692 1696 * Setup function pointers for generic logic in ··· 1734 1740 .queue_data_in = tcm_qla2xxx_queue_data_in, 1735 1741 .queue_status = tcm_qla2xxx_queue_status, 1736 1742 .queue_tm_rsp = tcm_qla2xxx_queue_tm_rsp, 1737 - .get_fabric_sense_len = tcm_qla2xxx_get_fabric_sense_len, 1738 1743 .set_fabric_sense_len = tcm_qla2xxx_set_fabric_sense_len, 1739 1744 /* 1740 1745 * Setup function pointers for generic logic in
-9
drivers/target/iscsi/iscsi_target_configfs.c
··· 1557 1557 return 2; 1558 1558 } 1559 1559 1560 - static u16 lio_get_fabric_sense_len(void) 1561 - { 1562 - /* 1563 - * Return two byte offset into allocated sense_buffer. 1564 - */ 1565 - return 2; 1566 - } 1567 - 1568 1560 static int lio_queue_tm_rsp(struct se_cmd *se_cmd) 1569 1561 { 1570 1562 struct iscsi_cmd *cmd = container_of(se_cmd, struct iscsi_cmd, se_cmd); ··· 1741 1749 fabric->tf_ops.queue_status = &lio_queue_status; 1742 1750 fabric->tf_ops.queue_tm_rsp = &lio_queue_tm_rsp; 1743 1751 fabric->tf_ops.set_fabric_sense_len = &lio_set_fabric_sense_len; 1744 - fabric->tf_ops.get_fabric_sense_len = &lio_get_fabric_sense_len; 1745 1752 /* 1746 1753 * Setup function pointers for generic logic in target_core_fabric_configfs.c 1747 1754 */
-6
drivers/target/loopback/tcm_loop.c
··· 851 851 return 0; 852 852 } 853 853 854 - static u16 tcm_loop_get_fabric_sense_len(void) 855 - { 856 - return 0; 857 - } 858 - 859 854 static char *tcm_loop_dump_proto_id(struct tcm_loop_hba *tl_hba) 860 855 { 861 856 switch (tl_hba->tl_proto_id) { ··· 1369 1374 fabric->tf_ops.queue_status = &tcm_loop_queue_status; 1370 1375 fabric->tf_ops.queue_tm_rsp = &tcm_loop_queue_tm_rsp; 1371 1376 fabric->tf_ops.set_fabric_sense_len = &tcm_loop_set_fabric_sense_len; 1372 - fabric->tf_ops.get_fabric_sense_len = &tcm_loop_get_fabric_sense_len; 1373 1377 1374 1378 /* 1375 1379 * Setup function pointers for generic logic in target_core_fabric_configfs.c
-6
drivers/target/sbp/sbp_target.c
··· 1852 1852 return 0; 1853 1853 } 1854 1854 1855 - static u16 sbp_get_fabric_sense_len(void) 1856 - { 1857 - return 0; 1858 - } 1859 - 1860 1855 static int sbp_check_stop_free(struct se_cmd *se_cmd) 1861 1856 { 1862 1857 struct sbp_target_request *req = container_of(se_cmd, ··· 2529 2534 .queue_data_in = sbp_queue_data_in, 2530 2535 .queue_status = sbp_queue_status, 2531 2536 .queue_tm_rsp = sbp_queue_tm_rsp, 2532 - .get_fabric_sense_len = sbp_get_fabric_sense_len, 2533 2537 .set_fabric_sense_len = sbp_set_fabric_sense_len, 2534 2538 .check_stop_free = sbp_check_stop_free, 2535 2539
-4
drivers/target/target_core_configfs.c
··· 461 461 pr_err("Missing tfo->set_fabric_sense_len()\n"); 462 462 return -EINVAL; 463 463 } 464 - if (!tfo->get_fabric_sense_len) { 465 - pr_err("Missing tfo->get_fabric_sense_len()\n"); 466 - return -EINVAL; 467 - } 468 464 /* 469 465 * We at least require tfo->fabric_make_wwn(), tfo->fabric_drop_wwn() 470 466 * tfo->fabric_make_tpg() and tfo->fabric_drop_tpg() in
-6
drivers/target/tcm_fc/tfc_conf.c
··· 495 495 { 496 496 } 497 497 498 - static u16 ft_get_fabric_sense_len(void) 499 - { 500 - return 0; 501 - } 502 - 503 498 static u16 ft_set_fabric_sense_len(struct se_cmd *se_cmd, u32 sense_len) 504 499 { 505 500 return 0; ··· 537 542 .queue_data_in = ft_queue_data_in, 538 543 .queue_status = ft_queue_status, 539 544 .queue_tm_rsp = ft_queue_tm_resp, 540 - .get_fabric_sense_len = ft_get_fabric_sense_len, 541 545 .set_fabric_sense_len = ft_set_fabric_sense_len, 542 546 /* 543 547 * Setup function pointers for generic logic in
-6
drivers/usb/gadget/tcm_usb_gadget.c
··· 1480 1480 return 0; 1481 1481 } 1482 1482 1483 - static u16 usbg_get_fabric_sense_len(void) 1484 - { 1485 - return 0; 1486 - } 1487 - 1488 1483 static const char *usbg_check_wwn(const char *name) 1489 1484 { 1490 1485 const char *n; ··· 1905 1910 .queue_data_in = usbg_send_read_response, 1906 1911 .queue_status = usbg_send_status_response, 1907 1912 .queue_tm_rsp = usbg_queue_tm_rsp, 1908 - .get_fabric_sense_len = usbg_get_fabric_sense_len, 1909 1913 .set_fabric_sense_len = usbg_set_fabric_sense_len, 1910 1914 .check_stop_free = usbg_check_stop_free, 1911 1915
-6
drivers/vhost/tcm_vhost.c
··· 336 336 return 0; 337 337 } 338 338 339 - static u16 tcm_vhost_get_fabric_sense_len(void) 340 - { 341 - return 0; 342 - } 343 - 344 339 static void vhost_scsi_free_cmd(struct tcm_vhost_cmd *tv_cmd) 345 340 { 346 341 struct se_cmd *se_cmd = &tv_cmd->tvc_se_cmd; ··· 1526 1531 .queue_data_in = tcm_vhost_queue_data_in, 1527 1532 .queue_status = tcm_vhost_queue_status, 1528 1533 .queue_tm_rsp = tcm_vhost_queue_tm_rsp, 1529 - .get_fabric_sense_len = tcm_vhost_get_fabric_sense_len, 1530 1534 .set_fabric_sense_len = tcm_vhost_set_fabric_sense_len, 1531 1535 /* 1532 1536 * Setup callers for generic logic in target_core_fabric_configfs.c
-1
include/target/target_core_fabric.h
··· 63 63 int (*queue_status)(struct se_cmd *); 64 64 int (*queue_tm_rsp)(struct se_cmd *); 65 65 u16 (*set_fabric_sense_len)(struct se_cmd *, u32); 66 - u16 (*get_fabric_sense_len)(void); 67 66 /* 68 67 * fabric module calls for target_core_fabric_configfs.c 69 68 */