Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

x86/entry/x32: Rename __x32_compat_sys_* to __x64_compat_sys_*

The SYSCALL macros are mapped to symbols as follows:

__SYSCALL_COMMON(nr, sym) --> __x64_<sym>
__SYSCALL_X32(nr, sym) --> __x32_<sym>

Originally, the syscalls in the x32 special range (512-547) were all
compat.

This assumption is now broken after the following commits:

55db9c0e8534 ("net: remove compat_sys_{get,set}sockopt")
5f764d624a89 ("fs: remove the compat readv/writev syscalls")
598b3cec831f ("fs: remove compat_sys_vmsplice")
c3973b401ef2 ("mm: remove compat_process_vm_{readv,writev}")

Those commits redefined __x32_sys_* to __x64_sys_* because there is no stub
like __x32_sys_*.

Defining them as follows is more sensible and cleaner.

__SYSCALL_COMMON(nr, sym) --> __x64_<sym>
__SYSCALL_X32(nr, sym) --> __x64_<sym>

This works because both x86_64 and x32 use the same ABI (RDI, RSI, RDX,
R10, R8, R9)

The ugly #define __x32_sys_* will go away.

Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210517073815.97426-2-masahiroy@kernel.org

authored by

Masahiro Yamada and committed by
Thomas Gleixner
2e958a8a 41f45fb0

+7 -19
+2 -14
arch/x86/entry/syscall_x32.c
··· 8 8 #include <asm/unistd.h> 9 9 #include <asm/syscall.h> 10 10 11 - /* 12 - * Reuse the 64-bit entry points for the x32 versions that occupy different 13 - * slots in the syscall table. 14 - */ 15 - #define __x32_sys_readv __x64_sys_readv 16 - #define __x32_sys_writev __x64_sys_writev 17 - #define __x32_sys_getsockopt __x64_sys_getsockopt 18 - #define __x32_sys_setsockopt __x64_sys_setsockopt 19 - #define __x32_sys_vmsplice __x64_sys_vmsplice 20 - #define __x32_sys_process_vm_readv __x64_sys_process_vm_readv 21 - #define __x32_sys_process_vm_writev __x64_sys_process_vm_writev 22 - 23 11 #define __SYSCALL_64(nr, sym) 24 12 25 - #define __SYSCALL_X32(nr, sym) extern long __x32_##sym(const struct pt_regs *); 13 + #define __SYSCALL_X32(nr, sym) extern long __x64_##sym(const struct pt_regs *); 26 14 #define __SYSCALL_COMMON(nr, sym) extern long __x64_##sym(const struct pt_regs *); 27 15 #include <asm/syscalls_64.h> 28 16 #undef __SYSCALL_X32 29 17 #undef __SYSCALL_COMMON 30 18 31 - #define __SYSCALL_X32(nr, sym) [nr] = __x32_##sym, 19 + #define __SYSCALL_X32(nr, sym) [nr] = __x64_##sym, 32 20 #define __SYSCALL_COMMON(nr, sym) [nr] = __x64_##sym, 33 21 34 22 asmlinkage const sys_call_ptr_t x32_sys_call_table[__NR_x32_syscall_max+1] = {
+5 -5
arch/x86/include/asm/syscall_wrapper.h
··· 17 17 * __x64_sys_*() - 64-bit native syscall 18 18 * __ia32_sys_*() - 32-bit native syscall or common compat syscall 19 19 * __ia32_compat_sys_*() - 32-bit compat syscall 20 - * __x32_compat_sys_*() - 64-bit X32 compat syscall 20 + * __x64_compat_sys_*() - 64-bit X32 compat syscall 21 21 * 22 22 * The registers are decoded according to the ABI: 23 23 * 64-bit: RDI, RSI, RDX, R10, R8, R9 ··· 166 166 * with x86_64 obviously do not need such care. 167 167 */ 168 168 #define __X32_COMPAT_SYS_STUB0(name) \ 169 - __SYS_STUB0(x32, compat_sys_##name) 169 + __SYS_STUB0(x64, compat_sys_##name) 170 170 171 171 #define __X32_COMPAT_SYS_STUBx(x, name, ...) \ 172 - __SYS_STUBx(x32, compat_sys##name, \ 172 + __SYS_STUBx(x64, compat_sys##name, \ 173 173 SC_X86_64_REGS_TO_ARGS(x, __VA_ARGS__)) 174 174 175 175 #define __X32_COMPAT_COND_SYSCALL(name) \ 176 - __COND_SYSCALL(x32, compat_sys_##name) 176 + __COND_SYSCALL(x64, compat_sys_##name) 177 177 178 178 #define __X32_COMPAT_SYS_NI(name) \ 179 - __SYS_NI(x32, compat_sys_##name) 179 + __SYS_NI(x64, compat_sys_##name) 180 180 #else /* CONFIG_X86_X32 */ 181 181 #define __X32_COMPAT_SYS_STUB0(name) 182 182 #define __X32_COMPAT_SYS_STUBx(x, name, ...)