tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
fork atom

NFS: Fix more sparse warnings

- fs/nfs/nfs4xdr.c:2499:42: warning: incorrect type in argument 2
(different signedness)
- fs/nfs/nfs4xdr.c:2658:49: warning: incorrect type in argument 4
(different explicit signedness)
- fs/nfs/nfs4xdr.c:2683:50: warning: incorrect type in argument 4
(different explicit signedness)
- fs/nfs/nfs4xdr.c:3063:68: warning: incorrect type in argument 4
(different explicit signedness)
- fs/nfs/nfs4xdr.c:3065:68: warning: incorrect type in argument 4
(different explicit signedness)

- fs/nfs/callback_xdr.c:138:31: warning: incorrect type in argument 2
(different signedness)

Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>

Trond Myklebust 2e42c3e2 10afec90

+5 -5
+2 -2
fs/nfs/callback.h
··· 24 24 }; 25 25 26 26 struct cb_compound_hdr_arg { 27 - int taglen; 27 + unsigned int taglen; 28 28 const char *tag; 29 29 unsigned int callback_ident; 30 30 unsigned nops; ··· 32 32 33 33 struct cb_compound_hdr_res { 34 34 __be32 *status; 35 - int taglen; 35 + unsigned int taglen; 36 36 const char *tag; 37 37 __be32 *nops; 38 38 };
+3 -3
fs/nfs/nfs4xdr.c
··· 2494 2494 int i; 2495 2495 dprintk("%s: using first %d of %d servers returned for location %d\n", __FUNCTION__, NFS4_FS_LOCATION_MAXSERVERS, m, res->nlocations); 2496 2496 for (i = loc->nservers; i < m; i++) { 2497 - int len; 2497 + unsigned int len; 2498 2498 char *data; 2499 2499 status = decode_opaque_inline(xdr, &len, &data); 2500 2500 if (unlikely(status != 0)) ··· 2642 2642 return 0; 2643 2643 } 2644 2644 2645 - static int decode_attr_owner(struct xdr_stream *xdr, uint32_t *bitmap, struct nfs_client *clp, int32_t *uid) 2645 + static int decode_attr_owner(struct xdr_stream *xdr, uint32_t *bitmap, struct nfs_client *clp, uint32_t *uid) 2646 2646 { 2647 2647 uint32_t len; 2648 2648 __be32 *p; ··· 2667 2667 return 0; 2668 2668 } 2669 2669 2670 - static int decode_attr_group(struct xdr_stream *xdr, uint32_t *bitmap, struct nfs_client *clp, int32_t *gid) 2670 + static int decode_attr_group(struct xdr_stream *xdr, uint32_t *bitmap, struct nfs_client *clp, uint32_t *gid) 2671 2671 { 2672 2672 uint32_t len; 2673 2673 __be32 *p;