Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

net: mvmdio: add select PHYLIB

The mvmdio driver uses the phylib API, so it should select the PHYLIB
symbol, otherwise, a build with mvmdio (but without mvneta) fails to
build with undefined symbols such as mdiobus_unregister, mdiobus_free,
etc.

The mvneta driver does not use the phylib API directly, so it does not
need to select PHYLIB. It already selects the mvmdio driver anyway.

Historically, this problem is due to the fact that the PHY handling
was originally part of mvneta, and was later moved to a separate
driver, without updating the Kconfig select statements
accordingly. And since there was no functional reason to use mvmdio
without mvneta, this case was not tested.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

authored by

Thomas Petazzoni and committed by
David S. Miller
2e0cbf2c fb745e9a

+1 -1
+1 -1
drivers/net/ethernet/marvell/Kconfig
··· 33 33 34 34 config MVMDIO 35 35 tristate "Marvell MDIO interface support" 36 + select PHYLIB 36 37 ---help--- 37 38 This driver supports the MDIO interface found in the network 38 39 interface units of the Marvell EBU SoCs (Kirkwood, Orion5x, ··· 46 45 config MVNETA 47 46 tristate "Marvell Armada 370/XP network interface support" 48 47 depends on MACH_ARMADA_370_XP 49 - select PHYLIB 50 48 select MVMDIO 51 49 ---help--- 52 50 This driver supports the network interface units in the