Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

drm/gma500: Disable PCI device during shutdown

Use managed disablement of PCI devices via pcim_device_enable().
Disables the PCI device and simplifies error rollback in probe
function.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210920141051.30988-3-tzimmermann@suse.de

+3 -7
+3 -7
drivers/gpu/drm/gma500/psb_drv.c
··· 448 448 struct drm_device *dev; 449 449 int ret; 450 450 451 - ret = pci_enable_device(pdev); 451 + ret = pcim_enable_device(pdev); 452 452 if (ret) 453 453 return ret; 454 454 455 455 dev = drm_dev_alloc(&driver, &pdev->dev); 456 - if (IS_ERR(dev)) { 457 - ret = PTR_ERR(dev); 458 - goto err_pci_disable_device; 459 - } 456 + if (IS_ERR(dev)) 457 + return PTR_ERR(dev); 460 458 461 459 pci_set_drvdata(pdev, dev); 462 460 ··· 472 474 psb_driver_unload(dev); 473 475 err_drm_dev_put: 474 476 drm_dev_put(dev); 475 - err_pci_disable_device: 476 - pci_disable_device(pdev); 477 477 return ret; 478 478 } 479 479