Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux

Merge branch 'for-linus' of git://brick.kernel.dk/data/git/linux-2.6-block

* 'for-linus' of git://brick.kernel.dk/data/git/linux-2.6-block:
[PATCH] blktrace: don't return blktrace_seq from trace_note()
[PATCH] blktrace: uninline trace_note()

+15 -18
+15 -18
block/blktrace.c
··· 31 31 /* 32 32 * Send out a notify message. 33 33 */ 34 - static inline unsigned int trace_note(struct blk_trace *bt, 35 - pid_t pid, int action, 36 - const void *data, size_t len) 34 + static void trace_note(struct blk_trace *bt, pid_t pid, int action, 35 + const void *data, size_t len) 37 36 { 38 37 struct blk_io_trace *t; 39 - int cpu = smp_processor_id(); 40 38 41 39 t = relay_reserve(bt->rchan, sizeof(*t) + len); 42 - if (t == NULL) 43 - return 0; 40 + if (t) { 41 + const int cpu = smp_processor_id(); 44 42 45 - t->magic = BLK_IO_TRACE_MAGIC | BLK_IO_TRACE_VERSION; 46 - t->time = sched_clock() - per_cpu(blk_trace_cpu_offset, cpu); 47 - t->device = bt->dev; 48 - t->action = action; 49 - t->pid = pid; 50 - t->cpu = cpu; 51 - t->pdu_len = len; 52 - memcpy((void *) t + sizeof(*t), data, len); 53 - return blktrace_seq; 43 + t->magic = BLK_IO_TRACE_MAGIC | BLK_IO_TRACE_VERSION; 44 + t->time = sched_clock() - per_cpu(blk_trace_cpu_offset, cpu); 45 + t->device = bt->dev; 46 + t->action = action; 47 + t->pid = pid; 48 + t->cpu = cpu; 49 + t->pdu_len = len; 50 + memcpy((void *) t + sizeof(*t), data, len); 51 + } 54 52 } 55 53 56 54 /* ··· 57 59 */ 58 60 static void trace_note_tsk(struct blk_trace *bt, struct task_struct *tsk) 59 61 { 60 - tsk->btrace_seq = trace_note(bt, tsk->pid, 61 - BLK_TN_PROCESS, 62 - tsk->comm, sizeof(tsk->comm)); 62 + tsk->btrace_seq = blktrace_seq; 63 + trace_note(bt, tsk->pid, BLK_TN_PROCESS, tsk->comm, sizeof(tsk->comm)); 63 64 } 64 65 65 66 static void trace_note_time(struct blk_trace *bt)